[Pkg-javascript-devel] Bug#665968: jquery: distfile does not contain complete source code

[Thorsten Glaser]

Source: jquery
Version: 1.7.2-1
Severity: serious
Justification: violates source requirement

Hi,

the jquery distfile (jquery_1.7.2.orig.tar.gz) does not contain
complete source code required for regenerating the dist/jquery.js
file as shipped. Indeed, it only contains a part of the main git
checkout without the required Sizzle submodule. Checking it out
from git, then trying to generate jquery.js, yields:

$ make jquery                                                                                               
make: *** No rule to make target `src/sizzle/sizzle.js', needed by `src/selector.js'. Stop.

Running “git clone --recursive https://github.com/jquery/jquery.git”
lets “make jquery” succeed.

I highly suggest you repack upstream source code and do NOT
ship the dist/jquery.js file, instead generating it during
Debian package build (this does not need node.js, since it
isn’t minified using their tools). The procedure for this
might look as follows:

git clone https://github.com/jquery/jquery.git
cd jquery
git checkout 1.7.2
git submodule update --init src/sizzle
cd src/sizzle
git checkout 1.5.1
cd ../../..
mv jquery jquery-1.7.2
find jquery-1.7.2 -type f | fgrep -v /.git | \
    paxcpio -oC512 -Hustar -Mdist | gzip -n9 \
    >jquery_1.7.2.orig.tar.gz

This requires pax (>= 1:20120216~) to be installed;
using GNU cpio for tar creation is discouraged as
it generates broken files, so use pax please. ;-)

Then, change override_dh_auto_build in debian/rules
to add one line before YUI which just says:
	${MAKE} jquery

That should suffice.


Another option is to use two distfiles, since you
use debian/source/format 3.0 (quilt) anyway, which
would allow you to properly version Sizzle.


If you want, I can do an NMU to that effect. I can
make these steps into a debian/rules get-orig-source
target, even.

HTH & HAND,
//mirabilos
-- 
tarent solutions GmbH
Rochusstraße 2-4, D-53123 Bonn • http://www.tarent.de/
Tel: +49 228 54881-393 • Fax: +49 228 54881-314
HRB AG Bonn 5168 • USt-ID (VAT): DE122264941
Geschäftsführer: Boris Esser, Elmar Geese