[Pkg-javascript-devel] Bug#591199: yui: does not build swf files from source

[Dominic Hargreaves]

On Sun, Nov 04, 2012 at 08:57:32PM -0500, Michael Gilbert wrote:
> control: reopen -1
> 
> >   * Several of the .swf files are now built from source and the rest have
> >    been removed from the package.  (Closes: #591199)
> 
> This seems to be incorrect about 2.9.0-1.  The following pre-built swf
> files still exist in the upstream tarball.
> 
> ./examples/storage/swfstore.swf
> ./examples/swf/assets/SWFExampleAdvanced.swf
> ./examples/swf/assets/SWFExampleSimple.swf
> ./examples/swfstore/swfstore.swf
H
> ./examples/uploader/assets/uploader.swf
> ./examples/charts/assets/expressinstall.swf
> ./build/connection/connection.swf
> ./build/swfstore/swfstore.swf
> ./build/uploader/assets/uploader.swf
> ./build/charts/assets/charts.swf
> ./tests/swf/tests/YUIBridgeProject.swf

There is no requirement that precompiled binaries must not be included
in source packages, only that they are rebuilt. The build system for
this package rebuilds, and overwrites

examples/storage/swfstore.swf
examples/swfstore/swfstore.swf
examples/uploader/assets/uploader.swf
build/connection/connection.swf
build/swfstore/swfstore.swf
build/uploader/assets/uploader.swf

(leaving

examples/swf/assets/SWFExampleAdvanced.swf
examples/swf/assets/SWFExampleSimple.swf
examples/charts/assets/expressinstall.swf
build/charts/assets/charts.swf
tests/swf/tests/YUIBridgeProject.swf

untouched).

The only swf files installed (and only as examples in the -doc pacakge)
are

examples/swfstore/swfstore.swf
examples/uploader/assets/uploader.swf
examples/storage/swfstore.swf

And these are rebuilt.

I recommend that this bug severity be downgraded to important and
retitled to reflect that the unrebuilt swf files present a risk if
later package modifications install them by mistake. Removing them
at build time is probably the safest/simplest way to do this.

If there are no other comments on this bug, I will effect this change
in one week.

-- 
Dominic Hargreaves | http://www.larted.org.uk/~dom/
PGP key 5178E2A5 from the.earth.li (keyserver,web,email)