[Pkg-javascript-devel] New jquery-lazyload version 1.8.4 - please review

[Emilien Klein]

Hi Jose Luis,

2013/2/27 Emilien Klein <emilien+debian at klein.st>:
> Hi team,
>
> I've updated the jquery-lazyload package in our Git repo [0] for the
> newest upstream version. I'd appreciate a review, and sponsored upload
> if all looks good.
>
> This change just updates the upstream version, but the previous
> changes I made to the package still need to be reviewed. Please find
> my previous mail indicating what had changed below.

Might you have some time to review these changes?
Thanks!
    +Emilien

> Cheers!
>     +Emilien
> [0] http://anonscm.debian.org/gitweb/?p=pkg-javascript/jquery-lazyload.git
>
> 2012/12/30 Emilien Klein <emilien+debian at klein.st>:
>> Hi team,
>>
>> I've updated the jquery-lazyload package in our Git repo [0] for the
>> newest upstream version. I'd appreciate a review, and sponsored upload
>> if all looks good.
>>
>> The biggest change with the previous packaged version (which wasn't
>> yet uploaded) is that the uncertainty around the license for the
>> images included in the upstream tarball has been resolved:
>> - As it turned out, the thumbnails were not properly licensed: quote
>> from [1]: "The small images are bit problematic. They were taken
>> almost 10 years ago in wakeboard competition I was organizing. They
>> are not taken by me and I also do not even remember the name of the
>> photographer."), those files have been removed by upstream
>> - The other images are now explicitly licensed under a CC license
>> (specified in the README.textile file)
>>
>> As follow up on our review discussion for the previous 1.8.0 version,
>> I had prepared a get-orig-source target in debian/rules (attached for
>> reference) that removed all the images, since they were not clearly
>> licensed. Another step was the removal of the minified files. Since I
>> was going to repackage [for the images], I'd remove those files as
>> well, but I don't think that those files by themselves justify a
>> repackaging. Remember that they are not used in the binary package, as
>> the file gets minified in the build process using uglifyjs... I assume
>> this is OK with our team's policy, please comment if you feel not.
>>
>> Thanks, and enjoy the last day of 2012!
>>    +Emilien
>>
>> [0] http://anonscm.debian.org/gitweb/?p=pkg-javascript/jquery-lazyload.git
>> [1] https://github.com/tuupola/jquery_lazyload/issues/73#issuecomment-11086261



--
   +Emilien
P.S.: Please CC me, as I'm not subscribed to this list.