<div dir="ltr">Indeed, it's just that "partially working" was a better outcome than "not working at all".<div><div><br></div><div>To explain why it was like that: latest node-nan detects nodejs version to decide wether</div><div><span style="font-size:13px">REPLACE_INVALID_UTF8</span> is available or not, and i implemented an "API-safe" workaround</div><div>for v8 that followed the node-nan approach.</div></div><div><br></div><div>Now adding that patch to libv8 might break API/ABI.</div><div>Luckily i have now abi-cc ready to check this. As soon i have i some time i'll add the patch</div><div>if it doesn't break anything else.</div><div><br></div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">2015-08-31 15:13 GMT+02:00 Ximin Luo <span dir="ltr"><<a href="mailto:infinity0@debian.org" target="_blank">infinity0@debian.org</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Package: libv8-3.14-dev<br>
Version: 3.14.5.8-10<br>
Severity: normal<br>
<br>
Hi,<br>
<br>
It's not so clear that the recent workaround for REPLACE_INVALID_UTF8 is<br>
such a good idea. In general, this sort of thing has the potential to lead<br>
to security problems.<br>
<br>
nodejs themselves manually patched their bundeled version of v8 specifically for this bug, see:<br>
<br>
<a href="https://github.com/nodejs/node/commits/v0.10.38-release/deps/v8/include/v8.h" rel="noreferrer" target="_blank">https://github.com/nodejs/node/commits/v0.10.38-release/deps/v8/include/v8.h</a><br>
<br>
which points to:<br>
<br>
<a href="https://github.com/nodejs/node/commit/881ac26f27f4ac9585d66c8d8a67d5b246a23d1b#diff-42f385dff7890b3c213d9699bcc350cc" rel="noreferrer" target="_blank">https://github.com/nodejs/node/commit/881ac26f27f4ac9585d66c8d8a67d5b246a23d1b#diff-42f385dff7890b3c213d9699bcc350cc</a><br>
<br>
We should probably import this, instead of the current "fix".<br>
<br>
X<br>
<br>
-- System Information:<br>
Debian Release: stretch/sid<br>
  APT prefers testing<br>
  APT policy: (990, 'testing'), (500, 'unstable'), (500, 'stable'), (1, 'experimental')<br>
Architecture: amd64 (x86_64)<br>
Foreign Architectures: i386<br>
<br>
Kernel: Linux 4.0.0-2-amd64 (SMP w/4 CPU cores)<br>
Locale: LANG=en_GB.utf8, LC_CTYPE=en_GB.utf8 (charmap=UTF-8)<br>
Shell: /bin/sh linked to /bin/dash<br>
Init: systemd (via /run/systemd/system)<br>
<br>
Versions of packages libv8-3.14-dev depends on:<br>
ii  libv8-3.14.5  3.14.5.8-10<br>
<br>
libv8-3.14-dev recommends no packages.<br>
<br>
libv8-3.14-dev suggests no packages.<br>
<br>
-- no debconf information<br>
<br>
_______________________________________________<br>
Pkg-javascript-devel mailing list<br>
<a href="mailto:Pkg-javascript-devel@lists.alioth.debian.org">Pkg-javascript-devel@lists.alioth.debian.org</a><br>
<a href="http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel" rel="noreferrer" target="_blank">http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel</a><br>
</blockquote></div><br></div>