[Pkg-jed-commit] r300 - in trunk/packages/jed-extra/debian: . examples init

Jörg Sommer joerg at alea.gnuu.de
Tue May 23 22:17:14 UTC 2006


Guenter Milde schrieb am Tue 23. May, 15:35 (+0000):
> Author: milde-guest
> Date: 2006-05-23 15:35:15 +0000 (Tue, 23 May 2006)
> New Revision: 300
> 
> Log:
> rules: variable VER for current version 
>        (Rafael, can you fix the extraction from the changelog?)

What's your problem?

> -CONTENTS_FILE = debian/contents.txt
> -
> -ADDITION = $(shell sed -n -e '/^A/ {s/^.\s*//; s@\s.*@/*@; p;}' $(CONTENTS_FILE))
> -COLOR = $(shell sed -n -e '/^C/ {s/^.\s*//; s@\s.*@/*@; p;}' $(CONTENTS_FILE))
> -DROP_IN = $(shell sed -n -e '/^D/ {s/^.\s*//; s@\s.*@/*@; p;}' $(CONTENTS_FILE))
> -ENHANCEMENT = $(shell sed -n -e '/^E/ {s/^.\s*//; s@\s.*@/*@; p;}' $(CONTENTS_FILE))
> -UTILS = $(shell sed -n -e '/^U/ {s/^.\s*//; s@\s.*@/*@; p;}' $(CONTENTS_FILE))
> -EXPERIMENTAL = $(shell sed -n -e '/^X/ {s/^.\s*//; s@\s.*@/*@; p;}' $(CONTENTS_FILE))
> -
>  debroot = $(PWD)/debian/jed-extra
> -libdir = /usr/share/jed/jed-extra
> -
> -dh_inst_excl = -X.html -X.otl -X.example -XREADME

Why did you cancel this change? It made backporting the package much
easier than a dependency on jed >= 0.99.17-111 (was it this version?) and
these lines are much easier to maintain than SLang code that generates a
config file for dh_install that installs the files.

Other opinions!

> +get-orig-source: jed-extra_$(VER).orig.tar.gz
> +	# The dependency on the archive file makes get-orig-source idempotent
> +
> +jed-extra_$(VER).orig.tar.gz:
> +	# latest non-released source tarball
> +	wget  http://jedmodes.sf.net/cvs/jedmodes-$(VER).tgz; \

Why a \ at the end?

> -
> -	mkdir --parents jedmodes-$(VER)/boxquote
> -	cd jedmodes-$(VER)/boxquote; \
> -	    wget http://www.cis.fu-berlin.de/~phgrau/slang/boxquote.sl
> -	gunzip jed-extra_$(VER).orig.tar.gz
> -	tar --append --file jed-extra_$(VER).orig.tar jedmodes-$(VER)
> -	gzip -9 jed-extra_$(VER).orig.tar

Do you not like boxquote?

>  clean: unpatch
>  	dh_testdir
>  	dh_clean
> @@ -52,45 +37,27 @@
>  	dh_testdir
>  	dh_testroot
>  	# keep dh_install informations (debian/files)
> -	dh_clean
> +	dh_clean --keep

Please, take a look at the manpage. --keep is not needed.

    -k, --keep
        Do not delete debian/files. When do you want to use this? Anytime
        you have a debian/rules that has 2 binary targets that build dif-
        ferent .deb packages; for example, one target is binary-arch, and
        the other is binary-indep, or one target builds the shared library,

> +	
> +	# fix apsconf permissions 
> +	# (executable in the Jedmodes CVS repository due to upload from Windoof)
> +	chmod -R a-x apsmode/*
> +	chmod a+x apsmode/apsconf/

This is not needed, too.

% tar -vtzf jed-extra_2.2.orig.tar.gz | grep '^-.*x '
%

> +	mv $$(find . -name \*.html -o -name \*.otl -name \*.example) \
> +	$(debroot)/usr/share/doc/jed-extra/mode-doc/

Why the README should be into the library dir?

Bye, Jörg.
-- 
Roesen's Law (http://www.bruhaha.de/laws.html):
Sobald ein Troll, DAU oder Elch im Lauf eines Threads auf heftige Kritik
stößt, argumentiert er mit der Arroganz des Kritikers. Dies kann auch
vorsorglich erfolgen.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 481 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-jed-devel/attachments/20060524/e38f310f/attachment.pgp


More information about the Pkg-jed-devel mailing list