[Pkg-jed-commit] r300 - in trunk/packages/jed-extra/debian: . examples init

[G. Milde]

On 26.05.06, Jörg Sommer wrote:
> Hallo G.,
> 
> G. Milde schrieb am Fri 26. May, 14:25 (+0200):
> > On 24.05.06, Jörg Sommer wrote:
> > > Guenter Milde schrieb am Tue 23. May, 15:35 (+0000):

> > > > rules: variable VER for current version 
> > > >        (Rafael, can you fix the extraction from the changelog?)
...
> > VER = $(shell perl -ne '/([\d.]+)-/; print $$1; exit' < \
> > 		      $(dir $(firstword $(MAKEFILE_LIST)))/changelog)
> > 
> > works in jed-extra/debian/rules, but for some reason not in
> > jed/debian/rules.
> 
> Why we need this? I would suggest to replace it by a string.

It releaves us from the need to update the VERsion in rules and build
scripts by taking it from the changelog.


> > Removing this was a side-effect of using my version of rules. It is in now,
> > but still buggy (creates the jedmodes-2.2 dir two times).
> 
> Fixed. BTW: Did this cause any trouble at you?

It did not break anything. But it troubled me, as I do not consider this
normal in a clean tar archive.


> > > > +	mv $$(find . -name \*.html -o -name \*.otl -name \*.example) \
> > > > +	$(debroot)/usr/share/doc/jed-extra/mode-doc/
... 
> > the version with 'mv' moves the documentation out of
> > the way. No need for "-X.html -X.otl -X.example -XREADME" with dh_install.
> 
> So, we should talk about what we understand of a clean build. I would
> prefer to make a whole build tree looks after an build+clean the same as
> before. Moving files out of the source tree is /bad/. If you create the
> sources of the package (e.g. the diff) after a build you get a broken
> source package.

Aha.

Still, even with "-X.html -X.otl -X.example -XREADME" for dh_install, all
the doc files ended up in both, doc/jed-extra/mode-doc/ and the libraries
during my test builds.

Günter



-- 
Milde ife.et.tu-dresden.de