[Pkg-jed-commit] r295 - in trunk/packages/jed-extra/debian: . init patches

[G. Milde]

On 26.05.06, Jörg Sommer wrote:
> Hallo G.,
> 
> G. Milde schrieb am Fri 26. May, 13:53 (+0200):
> > On 24.05.06, Jörg Sommer wrote:
> >  
> > > The source includes CVS conflict marks. That's more than an error. 
> > 
> > Indeed. That is a sign of something more strange going that definitely
> > requires a fix upstream... (it was the result of several CVS failures
> > at Sourceforge lately).
> 
> How can this happen with cvs export?

It happens because the tar archive is from a working copy and during CVS
failure changes were done to this working copy.

> > > And yes, I would do code cleanup like warnings, because they
> > > are an indicator of pitfalls.
> > 
> > But please not in a dpatch.
> 
> Where else? 

In a bug report. Saves a lot of work.

 
> > > > I am happy to receive bug reports, more to receive patches (with
> > > > explanation) but very unhappy with dpatches to my modes in a package I
> > > > maintain - without explanation about the bug they intend to fix.
> > > 
> > > If you refer to rst.dpatch and grep.dpatch it is more than self-evidently
> > > what's wrong there.
> > 
> > I did not find it out yet.
> 
> There were cvs conflict marks in the source.

This made it even more difficult to understand what else is changed.
Looking at a diff from a patch in a auto-generated commit report containing
conflict marks is not very straightforward for me. I did not easily find
where these conflict marks come from.


> I think we need rules they define what is a sane mode. Firstly, I would
> claim the mode must be loadable without any further actions, e.g. after
> a successful install of the package it must be possible to run
> 
> jed -batch -n -l MODE
> 
> If this fails, we missed anything in /etc/jed.d/50jed-extra.sl or the
> mode is broken.

No. This only applies to "basic" modes. We cannot add all configuration for
all modes in a non-invasive way. (see my other mail for this topic).
 
> > it saves a lot of autoload() lines in the code,
> > eases maintaining and makes the modes smaller.
> 
> 10 Bytes?

Up to 10% of code lines! But maintaining is the real point here: Hopefully
some of the functions from utils/ will be included in the Jed distribution
at some time --- possibly in a different file. Also the development of modes
using the utils might suggest a different clustering.


> > > > > * contents.txt:
> > > > 
> > > > Please only remove lines with modes not found in jedmodes.sf.net/mode/
> > > > (There are modes listed at Jedmodes with the sources outside the CVS
> > > > archive.)
> > > 
> > > If I consider this file as part of the Debian package I see no reason why
> > > we should keep track of modes not found in the orig.tar.gz.
> > 
> > For the record. There are interesting modes from other places that we
> > might want to add at a later point. 
> 
> Do you have any suggestions?

diff.sl by Dino Sangoi
abc.sl by Guido Gonzato

Günter