[Pkg-kde-commits] rev 1015 - branches/kde-3.4.0/cdbs people/chrsmrtn/cdbs-experimental

[Christopher Martin]

--nextPart4998658.yB1tImrOMv
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On April 22, 2005 03:32, Achim Bohnet wrote:
> On Thursday 21 April 2005 22:42, Christopher Martin wrote:
> > Author: chrsmrtn-guest
> > Date: 2005-04-21 20:42:27 +0000 (Thu, 21 Apr 2005)
> > New Revision: 1015
> >
> > Modified:
> >    branches/kde-3.4.0/cdbs/kde.mk
> >    people/chrsmrtn/cdbs-experimental/debian-qt-kde.mk
> > Log:
> > Add the rest of the fix, and remove the unnecessary stamping
> > of the patch itself - besides, it was kdewebdev specific
> > (this must have been what allee was getting at).
>
> Yes.

OK, I can be dense sometimes :)

> Isn't there a rm -f debian/stamp-patched missing in clean::
> missing.

No, stamp-patched is created and cleaned up by cdbs itself - this is just a=
=20
timestamp thing.

> Stupid question.  Why wasn't simple-patchsys.mk extended
> for .uu files.  It handles already diff.{gz,bz2}.
> I have not checked for special features of the kde.mk patch
> system.  But in case it's only the uu handling
> another case *.uu) cat=3D"uudecode -o -"  can be added.
>
>
> Independently replacing
>
> 		cd $(CURDIR)/debian/patches ; \
>                 uudecode $$i ; \
>                 cd $(CURDIR) ; \
>                 patch -N -p1 < "$${i%%.uu}" ; \
>
> with
> 		uudecode -o - $(CURDIR)/debian/patches/$$i | patch -N -p1
>
> should simply matters due to removing ambiguitiy if a .diff is from
> a .uu for a plain .diff file as well as it saves a temporary file.

Hmmm, this is so much nicer than the current method, it might simply be=20
worth using our own copy of simple-patchsys.mk for packages that need it=20
until upstream merges the patch (see Bug #305857). I'd been trying to avoid=
=20
that, but well...

Cheers,
Christopher Martin

--nextPart4998658.yB1tImrOMv
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)
Comment: Signed by Christopher Martin <chrsmrtn@freeshell.org>

iD8DBQBCaRe2U+gWW+vtsysRAgv4AJ9/pOLUYF2QEnxtpYfZuAfSDUQGPQCdH44u
TYheHnaxthC6Zc3xLT/Acxw=
=xxO5
-----END PGP SIGNATURE-----

--nextPart4998658.yB1tImrOMv--