[SCM] qtfeedback packaging branch, master, updated. 95cbd1016d603e3c867c15ceffca29b8faf32830
Timo Jyrinki
timo at moszumanska.debian.org
Tue Feb 11 06:00:58 UTC 2014
Gitweb-URL: http://git.debian.org/?p=pkg-kde/qt/qtfeedback.git;a=commitdiff;h=dd81db9
The following commit has been merged in the master branch:
commit dd81db95a95d01d5448f735e487190b2d6033195
Author: Timo Jyrinki <timo.jyrinki at iki.fi>
Date: Tue Feb 11 07:52:50 2014 +0200
Add disable_audio_playback_test.patch to run tests successfully
---
debian/patches/disable_audio_playback_test.patch | 105 +++++++++++++++++++++++
debian/patches/series | 1 +
2 files changed, 106 insertions(+)
diff --git a/debian/patches/disable_audio_playback_test.patch b/debian/patches/disable_audio_playback_test.patch
new file mode 100644
index 0000000..14b2bfc
--- /dev/null
+++ b/debian/patches/disable_audio_playback_test.patch
@@ -0,0 +1,105 @@
+Description: Disable an audio playback test in tst_qfeedbackmmk.cpp
+ This test fails on builders, although succeeds locally. It fails with:
+ QWARN : tst_QFeedbackMMK::goodFile() PulseAudioService: pa_context_connect() failed
+ Assertion 'c' failed at pulse/context.c:964, function pa_context_get_state(). Aborting.
+ even if pulseaudio is installed during build time.
+
+Author: Timo Jyrinki <timo.jyrinki at canonical.com>
+Last-Updated: 2013-10-30
+
+diff --git a/tests/auto/qfeedbackmmk/tst_qfeedbackmmk.cpp b/tests/auto/qfeedbackmmk/tst_qfeedbackmmk.cpp
+index 76f3390..939c160 100644
+--- a/tests/auto/qfeedbackmmk/tst_qfeedbackmmk.cpp
++++ b/tests/auto/qfeedbackmmk/tst_qfeedbackmmk.cpp
+@@ -62,7 +62,6 @@ public slots:
+ void cleanup();
+
+ private slots:
+- void goodFile();
+ void badFile();
+
+ private:
+@@ -112,83 +111,6 @@ void tst_QFeedbackMMK::cleanup()
+
+ Q_DECLARE_METATYPE(QFeedbackEffect::ErrorType);
+
+-void tst_QFeedbackMMK::goodFile()
+-{
+- QFeedbackFileEffect fe;
+- qRegisterMetaType<QFeedbackEffect::ErrorType>();
+- QSignalSpy errorSpy(&fe, SIGNAL(error(QFeedbackEffect::ErrorType)));
+- QSignalSpy stateSpy(&fe, SIGNAL(stateChanged()));
+-
+- QFileInfo fi(url.toLocalFile());
+- qDebug() << "URL for test data:" << url << url.toLocalFile() << fi.exists();
+-
+- fe.setSource(url);
+-
+- QTRY_COMPARE((int)fe.state(), (int)QFeedbackFileEffect::Loading);
+- QCOMPARE(errorSpy.count(), 0);
+- QCOMPARE(stateSpy.count(), 1); // Stopped to Loading
+-
+- // Wait for it to be loaded
+- QTRY_COMPARE((int)fe.state(), (int)QFeedbackFileEffect::Stopped);
+- QCOMPARE(errorSpy.count(), 0);
+- QCOMPARE(stateSpy.count(), 2); // Stopped to Loading to Stopped
+-
+- // Now play!
+- fe.start();
+-
+- // Now wait for it to be playing
+- QTRY_COMPARE((int)fe.state(), (int)QFeedbackFileEffect::Running);
+- QCOMPARE(errorSpy.count(), 0);
+- QCOMPARE(stateSpy.count(), 3); // Stopped to Loading to Stopped to Running
+- QVERIFY(fe.isLoaded());
+- QVERIFY(fe.duration() == 0); // unsupported :/
+-
+- // Try pausing - not supported
+- fe.pause(); // XXX this emits stateChanged even when it fails
+- QTRY_COMPARE((int)fe.state(), (int)QFeedbackFileEffect::Running);
+- QCOMPARE(errorSpy.count(), 1);
+- QCOMPARE(stateSpy.count(), 4); // Stopped to Loading to Stopped to Running
+-
+- // It should run out, eventually
+- QTRY_COMPARE((int)fe.state(), (int)QFeedbackFileEffect::Stopped);
+- QCOMPARE(errorSpy.count(), 1);
+- QCOMPARE(stateSpy.count(), 5); // Stopped to Loading to Stopped to Running to Stopped
+-
+- // Play it again..
+- fe.start();
+- QTRY_COMPARE((int)fe.state(), (int)QFeedbackFileEffect::Running);
+- QCOMPARE(errorSpy.count(), 1);
+- QCOMPARE(stateSpy.count(), 6); // Stopped to Loading to Stopped to Running to Stopped to Running
+-
+- fe.stop();
+- QTRY_COMPARE((int)fe.state(), (int)QFeedbackFileEffect::Stopped);
+- QCOMPARE(errorSpy.count(), 1);
+- QCOMPARE(stateSpy.count(), 7); // Stopped to Loading to Stopped to Running to Stopped to Running to Stopped
+-
+- fe.unload();
+- QTRY_COMPARE((int)fe.state(), (int)QFeedbackFileEffect::Stopped);
+- QCOMPARE(stateSpy.count(), 7); // no change
+- QCOMPARE(fe.isLoaded(), false);
+- QCOMPARE(fe.duration(), 0);
+-
+- // now load again
+- fe.load();
+-#ifdef Q_OS_MAC
+- QEXPECT_FAIL("", "QTBUG-25448", Abort);
+-#endif
+- QTRY_COMPARE((int)fe.state(), (int)QFeedbackFileEffect::Loading);
+- QCOMPARE(errorSpy.count(), 1);
+- QCOMPARE(stateSpy.count(), 8); // Stopped to Loading
+-
+- // Now wait for it to be loaded and playing
+- QTRY_COMPARE((int)fe.state(), (int) QFeedbackFileEffect::Stopped);
+- QCOMPARE(errorSpy.count(), 1);
+- QCOMPARE(stateSpy.count(), 9); // Stopped to Loading to Stopped
+- QVERIFY(fe.isLoaded());
+-
+- // destroy it while playing
+-}
+-
+ void tst_QFeedbackMMK::badFile()
+ {
+ QFeedbackFileEffect fe;
diff --git a/debian/patches/series b/debian/patches/series
index 462fa7f..f7b0d9d 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1 +1,2 @@
revert_module_version.patch
+disable_audio_playback_test.patch
--
qtfeedback packaging
More information about the pkg-kde-commits
mailing list