[SCM] kdeconnect packaging branch, master, updated. debian/0.9g-1-1183-g9d69498
Maximiliano Curia
maxy at moszumanska.debian.org
Fri Oct 14 14:26:53 UTC 2016
Gitweb-URL: http://git.debian.org/?p=pkg-kde/kde-extras/kdeconnect.git;a=commitdiff;h=2a55be4
The following commit has been merged in the master branch:
commit 2a55be4a3207f11c38f635c858f42a9ef0d50a7d
Author: Albert Vaca <albertvaka at gmail.com>
Date: Tue Sep 3 02:35:08 2013 +0200
Found a bug, added a FIXME because I do not have time for it
---
kded/plugins/mpriscontrol/mpriscontrolplugin.cpp | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/kded/plugins/mpriscontrol/mpriscontrolplugin.cpp b/kded/plugins/mpriscontrol/mpriscontrolplugin.cpp
index 185d63e..0018980 100644
--- a/kded/plugins/mpriscontrol/mpriscontrolplugin.cpp
+++ b/kded/plugins/mpriscontrol/mpriscontrolplugin.cpp
@@ -73,9 +73,10 @@ void MprisControlPlugin::serviceOwnerChanged(const QString &name,
void MprisControlPlugin::addPlayer(const QString& service)
{
QDBusInterface mprisInterface(service, "/org/mpris/MediaPlayer2", "org.mpris.MediaPlayer2");
+ //FIXME: This call hangs and returns an empty string if KDED is still starting!
const QString& identity = mprisInterface.property("Identity").toString();
playerList[identity] = service;
- qDebug() << "addPlayer" << service << identity;
+ qDebug() << "Mpris addPlayer" << service << "->" << identity;
sendPlayerList();
OrgFreedesktopDBusPropertiesInterface* freedesktopInterface = new OrgFreedesktopDBusPropertiesInterface(service, "/org/mpris/MediaPlayer2", QDBusConnection::sessionBus(), this);
@@ -128,7 +129,9 @@ void MprisControlPlugin::propertiesChanged(const QString& propertyInterface, con
void MprisControlPlugin::removePlayer(const QString& ifaceName)
{
- playerList.remove(playerList.key(ifaceName));
+ QString identity = playerList.key(ifaceName);
+ qDebug() << "Mpris removePlayer" << ifaceName << "->" << identity;
+ playerList.remove(identity);
sendPlayerList();
}
--
kdeconnect packaging
More information about the pkg-kde-commits
mailing list