[SCM] exiv2 packaging branch, master, updated. debian/0.25-3.1-3734-gdcbc29a

[Maximiliano Curia]

Gitweb-URL: http://git.debian.org/?p=pkg-kde/kde-extras/exiv2.git;a=commitdiff;h=5e66d62

The following commit has been merged in the master branch:
commit 5e66d62613cfd9f5d6ee1438cddf063bf1343557
Author: Andreas Huggel <ahuggel at gmx.net>
Date:   Tue Nov 11 15:05:47 2008 +0000

    Minor changes: removed some comments, added a warning.
---
 src/preview.cpp     | 3 +++
 src/tiffimage.cpp   | 8 --------
 src/tiffvisitor.cpp | 5 -----
 3 files changed, 3 insertions(+), 13 deletions(-)

diff --git a/src/preview.cpp b/src/preview.cpp
index e7ee921..3c6e7e5 100644
--- a/src/preview.cpp
+++ b/src/preview.cpp
@@ -410,6 +410,9 @@ namespace {
             height_ = image->pixelHeight();
         }
         catch (const AnyError& /* error */ ) {
+#ifndef SUPPRESS_WARNINGS
+            std::cerr << "Warning: Invalid JPEG preview image.
";
+#endif
             return false;
         }
 
diff --git a/src/tiffimage.cpp b/src/tiffimage.cpp
index 17a865e..49ab9bd 100644
--- a/src/tiffimage.cpp
+++ b/src/tiffimage.cpp
@@ -59,12 +59,6 @@ EXIV2_RCSID("@(#) $Id$")
 
    Todo:
 
-   + Review boundary checking, is it better to check the offsets?
-   + Define and implement consistent error handling for recursive hierarchy
-   + Make TiffImage a template StandardImage, which can be parametrized with
-     a parser and the necessary checking functions to cover all types of
-     images which need to be loaded completely.
-   + TiffComponent: should it have end() and setEnd() or pData and size?
    + Can NewTiffCompFct and TiffCompFactoryFct be combined?
    + Create function is repeated when actually only the table changes. Fix it.
    + Is it easier (for writing) to combine all creation tables into one?
@@ -74,8 +68,6 @@ EXIV2_RCSID("@(#) $Id$")
      And maybe no next pointer either.
    + Filtering of large unknown tags: Should be moved to writing/encoding code
      and done only if really needed (i.e., if writing to a Jpeg segment)
-   + Make Tiff parser completely standalone, depending only on very low level
-     stuff from exiv2
 
    in crwimage.* :
 
diff --git a/src/tiffvisitor.cpp b/src/tiffvisitor.cpp
index 5b87a97..44c2dfe 100644
--- a/src/tiffvisitor.cpp
+++ b/src/tiffvisitor.cpp
@@ -853,11 +853,6 @@ namespace Exiv2 {
 
             // Assumption is that the corresponding TIFF entry doesn't exist
 
-            // Todo: This takes tag and group straight from the Exif datum.
-            // There is a need for a simple mapping and a provision for quite
-            // sophisticated logic to determine the mapped tag and group to
-            // handle complex cases (eg, NEF sub-IFDs)
-
             // Todo: getPath depends on the Creator class, not the createFct
             //       how to get it through to here???
 

-- 
exiv2 packaging