[Pkg-kde-extras] Re: kmplayer package review

[Fathi Boudra]

> The latest from the marillat archive (ftp.nerim.net) is 1:0.9.1c-0.0, which
> with the epoc 1: is greater than what we currently have in svn.debian.org.
> Which would make upgrades difficult for people who are already using the
> unofficial archive.

agreed. it would be nice to find a solution for users using christian's 
unofficial repository to do a smooth transition to debian kmplayer package.

> > Yes, this package should go in contrib due to the mplayer dependency.

> kmplayer despite the name no longer solely depends on mplayer to provide a
> functional media player.  In fact the way it has been packaged for Debian
> in svn.debian is that it only depends on the free xine to provide media
> player functionality and this should go in main and not contrib. It also
> can use a gstreamer backend, which, whilst also free, has been disabled for
> the Debian package.

seconded.

> > Of course mplayer is needed. See in src/kmplayerprocess.cpp
> > In the same source, mencoder is also called which is definitely not
> > free. The README file isn't ambiguous :
> > ----
> >
> > | KMPlayer needs KDE3.1 and a working mplayer/mencoder somewhere in you
> > | PATH.
> >
> > `----
> >
> > So kmplayer should go in contrib or all the code related to
> > mplayer/mencoder need to be removed and then kmplayer can go in main.

from http://www.debian.org/doc/debian-policy/ch-archive.html#s-main :
> must not require a package outside of main for compilation or execution
> (thus, the package must not declare a "Depends", "Recommends", or
> "Build-Depends" relationship on a non-main package),

kmplayer doesn't require mplayer for compilation and execution, it doesn't 
depends, recommends, or build-depends on a non-main package.

kmplayer works fine without mplayer. mplayer enhances kmplayer and isn't 
needed. The code you talk about is just a kprocess call to mencoder.

I think that we aren't agree on the interpretation of "execution" term.

You claims that README file isn't ambigious, i think the opposite :

* from website homepage:
> A new name, KMPlayer sounds like a frontend to MPlayer, no ?

* from website install page:
> Although not really needed, KMPlayer assumes you have a working mplayer
> somewhere in your PATH (comment out gui=yes in your mplayer config file,
> use gmplayer for MPlayer's own GUI instead) Support for Xine, GStreamer
> and/or ffmpeg is optional, but the Xine backend is highly recommended esp.
> if you want to watch DVD. Of course, you need at least one of mplayer, xine
> or gstreamer to play anything at all. Install xine-lib and ffmpeg if you
> want it. You should install xine-lib before compiling kmplayer (and don't
> forget to run ldconfig if you compile/install xine-lib yourself). Same goes
> for GStreamer. MPlayer and ffmpeg can be installed afterwards.

* from koos:
> However do consider that most kmplayer users are plugin users, because
> there is no real alternative (one that doesn't make konqueror crash).

So i want to focus on the plugin, as kaffeine is a good alternative to the 
player.

> you might consider setting the xine player as default (because xine is in
> debian)

All peoples know the mplayer issue, so the choice was made to use xine as 
default backend for debian and kubuntu.