[Pkg-kde-extras] Re: kmplayer package review

[Achim Bohnet]

On Tuesday 04 April 2006 22:22, Mark Purcell wrote:
> On Tuesday 04 April 2006 17:20, Fathi Boudra wrote:
> > i've added kmplayer to kde-extras. The package lacks of 2 manpages that
> > i'll write as soon as possible. If you've got some time, can you please
> > review it ?

o Postinst and postrm do nothing so remove them.
o copyright mention GPL and LGPL but there's only the GPL header from
  src not LGPL.
o copyright years missing for Koos in copyright
o cdbs has utils.mk with has a list-missing target. This looks more
  useful than the --list-missing from debhelpers.
o if kxvplayer can't be used standalone(?) it should be moved to 
  /usr/lib/kmplayer/ and full path used in kmplayer source code.
  => one lintian warning to suppress less ;)
> 
> Fathi,
> 
> Even though you have filed the first ITP, you might like to check with 
> Christian Marillat as he has kmplayer in his archives and your changelog 
> should at least follow on from his..  Especially since his last version 
> number is 1:0.9.1c-0.0 which is greater then your proposal.

Oh, I wasn't aware of this otherwise I would have pointed kubuntu devels to
it :(

I also a fan of add/keep of changelog and entires and keep a list of
people that worked on the pkg at the top of copyright.
IMHO this is polite if one uses parts or devired from their pkg (first
impression is you started on your own).

> 
> Ubuntu also have a package so it might be good to sync changes with them.

Have a look at the kmplayer manpage.  Not much in it too, but a bit more.

Achim

> Christian, Jonathan, The Debian KDE-Extras team has uploaded kmplayer to 
> http://svn.debian.org/wsvn/pkg-kde/kde-extras/ and we shall upload to the 
> debian unstable archive shortly. If you have any suggestions for packaging 
> please let us know and/or would like to work with us, please follow the 
> README in svn.
> 
> Mark
> 

-- 
  To me vi is Zen.  To use vi is to practice zen. Every command is
  a koan. Profound to the user, unintelligible to the uninitiated.
  You discover truth everytime you use it.
                                      -- reddy at lion.austin.ibm.com