[Pkg-kde-extras] Re: libkexif, libkipi, kipi-plugins relibtoolize required

[Achim Bohnet]

On Tuesday 09 May 2006 23:56, Mark Purcell wrote:
> On Tuesday 09 May 2006 22:41, Achim Bohnet wrote:
> > While rebuilding for debugging digikam I played with these ideas.  Simplest
> > way I found to make LIB_QT=-lqt-mt, instead of
> > LIB_QT = -lqt-mt  $(LIBZ) $(LIBPNG) -lXext $(LIB_X11) $(LIBSM) -lpthread
> 
> I have grabbed and checked in the common patches for libkipi, and dropped the 
> rest Makefile & buildprep.
> 
> It seems to build find and allready pull the necessary qt-mt dependancies 
> during build.

Check the build log.  All Makefile* files are rebuild after configure runs
(due to the common-patches).  The buildprep script and diff fixes this.
So it will fail in pbuilder due to missing build-deps.   Rule: don't use
stuff from common-patches without buildprep.

> Have I missed a trick, or is as checked in going to work without the need to 
> patch configure?

yeap, you missed the trick ;)  Nothing complains during build time when you link
against too many shared libs

allee(0) ~/src/libkipi/0.1.3/libkipi-0.1.3 $ grep ^LIB_QT `find . -name Makefile`
./obj-i486-linux-gnu/Makefile:LIB_QT = -lqt-mt  $(LIBZ) $(LIBPNG) -lXext $(LIB_X11) $(LIBSM) -lpthread
./obj-i486-linux-gnu/libkipi/Makefile:LIB_QT = -lqt-mt  $(LIBZ) $(LIBPNG) -lXext $(LIB_X11) $(LIBSM) -lpthread
./obj-i486-linux-gnu/libkipi/libkipi/Makefile:LIB_QT = -lqt-mt  $(LIBZ) $(LIBPNG) -lXext $(LIB_X11) $(LIBSM) -lpthread
./obj-i486-linux-gnu/doc/Makefile:LIB_QT = -lqt-mt  $(LIBZ) $(LIBPNG) -lXext $(LIB_X11) $(LIBSM) -lpthread
...

A lintian test once posted on debian-devel uncovers the same issue:

...
Now running lintian...
W: libkipi0: unneeded-explicit-linking usr/lib/libkipi.so.0.1.0 libz.so.1 libgcc_s.so.1 libX11.so.6 libSM.so.6 libpng12.so.0 libICE.so.6 libXext.so.6
Finished running lintian.
...

All other relibtoolize stuff was fixed by me upstream:

2005-12-08 00:31  ach

        * trunk/extragear/libs/libkipi/libkipi/Makefile.am: libkipi: List
          _all_ libs in _LDADD from which libkipi needs symbols:
          -libkipi_la_LIBADD = $(LIB_KIO) $(LIB_KUI) +libkipi_la_LIBADD =
          $(LIB_KIO) $(LIB_KDEUI) $(LIB_KDECORE) $(LIB_QT) OT ;) at least
          for linux and shared libs the LIB_QT var (== -lqt-mt $(LIBZ)
          $(LIBPNG) -lXext $(LIB_X11) $(LIBSM) -lpthread) is better
          replaced by -lqt-mt. Otherwise the loader adds 20 additional
          libraries as NEEDED to libkipi. CCMail:digikam-devel at kde.org



Achim

-- 
  To me vi is Zen.  To use vi is to practice zen. Every command is
  a koan. Profound to the user, unintelligible to the uninitiated.
  You discover truth everytime you use it.
                                      -- reddy at lion.austin.ibm.com