[Pkg-kde-extras] Bug#462239: FTBFS with GCC 4.3: missing #includes

[Martin Michlmayr]

Package: tora
Version: 1.3.22-6
Severity: important
Usertags: ftbfs-gcc-4.3

Your package fails to build with GCC 4.3.  Version 4.3 has not been
released yet but I'm building with a snapshot in order to find errors
and give people an advance warning.  In GCC 4.3, the C++ header
dependencies have been cleaned up.  The advantage of this is that
programs will compile faster.  The downside is that you actually
need to directly #include everything you use (but you really should
do this anyway, otherwise your program won't work with any compiler
other than GCC).  There's some more information about this at
http://gcc.gnu.org/gcc-4.3/porting_to.html

You can reproduce this problem with gcc-4.3 or gcc-snapshot from
unstable.

> Automatic build of tora_1.3.22-6 on em64t by sbuild/amd64 0.53
...
> if g++ -DHAVE_CONFIG_H -I. -I. -I..  -I../ext/otl -I../ext/loki/loki-0.1.6/include -I/usr/include/kde -I/usr/share/qt3/include   -DDEFAULT_PLUGIN_DIR=\"/usr/share/tora\" -DTOVERSION=\"1.3.22\"  -I/usr/include/qscintilla   -DQT_THREAD_SUPPORT -g -O2 -D_REENTRANT -MT tora-utils.o -MD -MP -MF ".deps/tora-utils.Tpo" -c -o tora-utils.o `test -f 'utils.cpp' || echo './'`utils.cpp; \
> 	then mv -f ".deps/tora-utils.Tpo" ".deps/tora-utils.Po"; else rm -f ".deps/tora-utils.Tpo"; exit 1; fi
> if g++ -DHAVE_CONFIG_H -I. -I. -I..  -I../ext/otl -I../ext/loki/loki-0.1.6/include -I/usr/include/kde -I/usr/share/qt3/include   -DDEFAULT_PLUGIN_DIR=\"/usr/share/tora\" -DTOVERSION=\"1.3.22\"  -I/usr/include/qscintilla   -DQT_THREAD_SUPPORT -g -O2 -D_REENTRANT -MT tora-SmallObj.o -MD -MP -MF ".deps/tora-SmallObj.Tpo" -c -o tora-SmallObj.o `test -f '../ext/loki/loki-0.1.6/src/SmallObj.cpp' || echo './'`../ext/loki/loki-0.1.6/src/SmallObj.cpp; \
> 	then mv -f ".deps/tora-SmallObj.Tpo" ".deps/tora-SmallObj.Po"; else rm -f ".deps/tora-SmallObj.Tpo"; exit 1; fi
> ../ext/loki/loki-0.1.6/src/SmallObj.cpp:296: error: 'UCHAR_MAX' was not declared in this scope
> ../ext/loki/loki-0.1.6/src/SmallObj.cpp: In member function 'bool Loki::Chunk::IsCorrupt(unsigned char, size_t, bool) const':
> ../ext/loki/loki-0.1.6/src/SmallObj.cpp:428: error: 'UCHAR_MAX' was not declared in this scope
> ../ext/loki/loki-0.1.6/src/SmallObj.cpp:428: error: template argument 1 is invalid
> ../ext/loki/loki-0.1.6/src/SmallObj.cpp:428: error: invalid type in declaration before ';' token
> ../ext/loki/loki-0.1.6/src/SmallObj.cpp:460: error: request for member 'set' in 'foundBlocks', which is of non-class type 'int'
> ../ext/loki/loki-0.1.6/src/SmallObj.cpp:475: error: request for member 'test' in 'foundBlocks', which is of non-class type 'int'
> ../ext/loki/loki-0.1.6/src/SmallObj.cpp:486: error: request for member 'count' in 'foundBlocks', which is of non-class type 'int'
> ../ext/loki/loki-0.1.6/src/SmallObj.cpp: In member function 'bool Loki::Chunk::IsBlockAvailable(void*, unsigned char, size_t) const':
> ../ext/loki/loki-0.1.6/src/SmallObj.cpp:522: error: 'UCHAR_MAX' was not declared in this scope
> ../ext/loki/loki-0.1.6/src/SmallObj.cpp:522: error: template argument 1 is invalid
> ../ext/loki/loki-0.1.6/src/SmallObj.cpp:522: error: invalid type in declaration before ';' token
> ../ext/loki/loki-0.1.6/src/SmallObj.cpp:527: error: request for member 'set' in 'foundBlocks', which is of non-class type 'int'
> ../ext/loki/loki-0.1.6/src/SmallObj.cpp:536: error: request for member 'test' in 'foundBlocks', which is of non-class type 'int'
> make[4]: *** [tora-SmallObj.o] Error 1
> make[4]: Leaving directory `/build/tbm/tora-1.3.22/src'
> make[3]: *** [all] Error 2
> make[3]: Leaving directory `/build/tbm/tora-1.3.22/src'

-- 
Martin Michlmayr
http://www.cyrius.com/