[Pkg-kde-extras] Bug#678714: [kde-gtk-config] src: Fix freezing problem on load

[Aleix Pol]

On Sun, Jul 15, 2012 at 9:52 AM, Boris Pek <Tehnick-8 at yandex.ru> wrote:
>> Git commit 81b7e1e43e5fce39ace676ef40637059b9bb9317 by Aleix Pol.
>> Committed on 11/07/2012 at 13:29.
>> Pushed by apol into branch 'master'.
>>
>> Fix freezing problem on load
>>
>> Don't iterate over the home directory, this happened in cases
>> where the fallback icon theme was set to "" and Qt translated it
>> to QDir("") which was CWD.
>>
>> CCMAIL: 678714 at bugs.debian.org
>>
>> M  +6    -2    src/gtkconfigkcmodule.cpp
>> M  +1    -0    src/iconthemesmodel.cpp
>>
>> http://commits.kde.org/kde-gtk-config/81b7e1e43e5fce39ace676ef40637059b9bb9317
>
> Hi,
>
> Sorry for delay, I am on vacation now.
>
> I prepared own patches some time ago [1][2]. And updated package [3] is
> currently waiting [4] for a freeze exception [5]. If freeze exception is
> granted package will be uploaded.
>
> Regards,
> Boris
>
> [1] https://github.com/tehnick/kde-gtk-config-debian/blob/master/debian/patches/ignore-symlinks
> [2] https://github.com/tehnick/kde-gtk-config-debian/blob/master/debian/patches/fix-loading-icons
> [3] http://mentors.debian.net/package/kde-gtk-config
> [4] https://lists.debian.org/debian-release/2012/07/msg00262.html
> [5] http://release.debian.org/wheezy/freeze_policy.html

Hi Boris,
the [1] patch is not really useful. It's removing symlinks but it's
not harmful to follow them in this case. It's not a
recursive/iterative function so it's harmless. It shouldn't be
applied.
the [2] patch, on one part is fixing the bug like i did, on the other
it's setting the first entry in the combo box for no apparent
reason...

I'd suggest you to go through KDE to improve the application instead
of applying patches to your package. It might improve the package
sooner, but review is important and I prefer to be responsible myself
of the software I maintain.

Aleix