[Pkg-kde-extras] Bug#836065: strigi: please use dbus-run-session, or dbus-daemon directly, in tests

[Simon McVittie]

Source: strigi
Version: 0.7.8-2.2
Severity: normal
Tags: upstream
User: dbus at packages.debian.org
Usertags: dbus-launch dbus-launch-for-tests

As described in <https://lists.debian.org/debian-devel/2016/08/msg00554.html>
I'm trying to reduce how much dbus-launch is used in Debian.
This package currently uses dbus-launch explicitly in its unit tests.

The test executables could be run through dbus-run-session(1), which is
available since dbus 1.8, the upstream "old stable" branch available in
Debian stable. That would look something like this:

    dbus-run-session -- make check

Alternatively, this Flatpak commit illustrates how `eval dbus-launch` can be
replaced by invoking dbus-daemon directly, avoiding the X11-specific
dbus-launch:
<https://github.com/flatpak/flatpak/commit/6cc8062cfb3f9410d54a27e7ccca77c103e441e8>.
This is essentially what GTestDBus does. There is equivalent C code in
<https://cgit.freedesktop.org/dbus/dbus/tree/test/test-utils-glib.c>
(look for "--print-address").

It is possible to send both the address and the pid to stdout
("--print-address=1 --print-pid=1") if that would be easier to do from
Qt; their order is undocumented but predictable, and I don't intend
to break it in future D-Bus releases.

Thanks,
    S