[Pkg-libvirt-maintainers] Bug#654847: Bug#654847: gvncviewer: enable gvncviewer to connect to unix domain sockets

Guido Günther agx at sigxcpu.org
Tue Jan 10 11:04:13 UTC 2012


Hi Daniel,

On Fri, Jan 06, 2012 at 02:18:48AM -0500, Daniel Kahn Gillmor wrote:
> Package: gvncviewer
> Version: 0.5.0-2
> Severity: normal
> Tags: patch
> 
> gvncviewer can't currently connect to VNC servers running over unix
> domain sockets, such as those provided by the qemu and kvm utilities.
> 
> The attached patch enables this feature.  It should apply cleanly at
> the end of the current patch series in gvncviewer 0.5.0-2.
> 
> The logic is: test the provided hostname to see if a matching file exists and
> is a unix-domain socket.  If it is, try to connect to it that way.  otherwise,
> proceed with argument parsing and TCP sockets as usual.
> 
> I've also filed this with upstream at:
> 
>   https://bugzilla.gnome.org/show_bug.cgi?id=667396

Patch looks good to me. I'd feel even more comfortable applying it, if
it went in upstream. The upstream list is gtk-vnc-list at gnome.org and
usually get's quicker responses than the bugtracker.
Cheers,
 -- Guido





More information about the Pkg-libvirt-maintainers mailing list