[Pkg-libvirt-maintainers] Bug#594444: Bug#594444: libvirt-bin: "virsh edit <domain>" should fall back to /usr/bin/editor if $EDITOR is not set

Dmitry Smirnov onlyjob at debian.org
Sun Jul 20 02:55:58 UTC 2014


On Fri, 18 Jul 2014 13:28:12 Guido Günther wrote:
> Good idea! But shouldn't this be sensible-editor on Debian as per
> 11.4. of policy.

I think `editor` is sufficient because it is a symbolic link to
`/etc/alternatives/editor`. As far as I understand `sensible-editor` will 
prioritise VISUAL environment variable and therefore might invoke X editor 
which is perhaps just a little bit too far from upstream behaviour. `editor` 
and `sensible-editor` are managed by the same alternatives system so IMHO it's 
not too important which one to use. I tend to prefer `editor` because it is 
more straightforward. Please feel free to correct the patch as per your 
preferences. :)

Thanks.

-- 
Best wishes,
 Dmitry Smirnov.

---

Science embraces facts and debates opinion; religion embraces opinion
and debates the facts.
        -- Tom Heehler, The Well-Spoken Thesaurus.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.alioth.debian.org/pipermail/pkg-libvirt-maintainers/attachments/20140720/393d75cd/attachment.sig>


More information about the Pkg-libvirt-maintainers mailing list