[Pkg-libvirt-maintainers] Bug#837659: hivex: FTBFS with bindnow and PIE enabled

[Balint Reczey]

Source: hivex
Version: 1.3.13-2
Severity: important
User: balint at balintreczey.hu
Usertags: pie-bindnow-20160906
Justification: FTBFS on amd64 with extra hardening

Hi,

During a rebuild of all packages in sid, your package failed to build on
amd64 with patched GCC and dpkg.

The rebuild tested if packages are ready for a transition
enabling PIE and bindnow for amd64.

For more information about the changes to sid's dpkg and GCC please
visit:
 https://wiki.debian.org/Hardening/PIEByDefaultTransition

Relevant part (hopefully):
...
Making all in ocaml
make[4]: Entering directory '/<<PKGBUILDDIR>>/debian/build-default/ocaml'
gcc -I.. -I/usr/lib/ocaml -I../../../ocaml -I../../../lib   -g -O2
-fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat
-Werror=format-security -fPIC -Wall -c ../../../ocaml/hivex_c.c
../../../ocaml/hivex_c.c:52:1: error: static declaration of
'caml_raise_with_args' follows non-static declaration
 caml_raise_with_args (value tag, int nargs, value args[])
 ^~~~~~~~~~~~~~~~~~~~
In file included from ../../../ocaml/hivex_c.c:39:0:
/usr/lib/ocaml/caml/fail.h:32:17: note: previous declaration of
'caml_raise_with_args' was here
 CAMLextern void caml_raise_with_args (value tag, int nargs, value arg[])
                 ^~~~~~~~~~~~~~~~~~~~
../../../ocaml/hivex_c.c: In function 'raise_error':
../../../ocaml/hivex_c.c:1057:1: warning: 'noreturn' function does return
 }
 ^
Makefile:1696: recipe for target 'hivex_c.o' failed
make[4]: *** [hivex_c.o] Error 1
make[4]: Leaving directory '/<<PKGBUILDDIR>>/debian/build-default/ocaml'
Makefile:1276: recipe for target 'all-recursive' failed
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory '/<<PKGBUILDDIR>>/debian/build-default'
Makefile:1183: recipe for target 'all' failed
make[2]: *** [all] Error 2
...

The full build log is available from:
 https://people.debian.org/~rbalint/build-logs/pie-bindnow-20160906/hivex_1.3.13-2_amd64.build.gz

Thanks,
Balint