[Pkg-ltsp-devel] Bug#421324: ldm: NETWORK_COMPRESSION=False in client /etc/lts.conf not honoured

[Tim Day]

Package: ldm
Version: 0.99debian11
Severity: normal
Tags: patch

While debian doesn't include much ltsp docs, googling leads me to believe
that putting
  NETWORK_COMPRESSION=False
into my client's /etc/lts.conf should disable ssh compression.
However, ssh is always being invoked with the -C option.

I think /usr/sbin/ldm needs patching thus:

diff ldm.orig ldm
193c193
<             if 'NETWORK_COMPRESSION' in os.environ:
---
>             if 'NETWORK_COMPRESSION' in os.environ and get_config_bool('NETWORK_COMPRESSION'):

or at least that's what I've done locally and it seems to work as intended.
(Although I imagine pushing the existence test down into get_config_bool,
with the not-present default value as an additional argument might be a
superior approach).

[I just have one 1Ghz Via Mini-ITX client; for a graphics intensive app I find
while disabling compression raises bandwidth from ~10Mbit to ~25Mbit, and
framerate doesn't actually increase much at all (+25-30%?), the sshd on
the 2.4GHz P4 server drops from 50% CPU to 10% (ssh time on client pretty
much the same).  This is a better setup for me than with compression; I just
mention this in case you were planning on getting rid of control over compression
completely!]

-- System Information:
Debian Release: 4.0
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.18-4-686
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)