[Pkg-ltsp-devel] [RFR] templates://ltsp/{ltsp-client-builder.templates, ltsp-client-core.tem plates}

Christian Perrier bubulle at debian.org
Sat Jul 7 16:31:49 UTC 2007


Please find, for review, the debconf templates of ltsp.

This review will last from Friday, July 06, 2007 to Monday, July 16, 2007.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, the reviewed templates will be sent to the package maintainer
as a bug report, and a mail will be sent to this list with "[BTS]" as
a subject tag.

Rationale:

--- ltsp.old/debian/ltsp-client-builder.templates	2007-06-21 10:27:51.637725911 +0200
+++ ltsp/debian/ltsp-client-builder.templates	2007-06-28 07:51:07.840901865 +0200
@@ -2,8 +2,8 @@
 Type: boolean
 Default: false
 _Description: Set up an LTSP chroot environment?
- This will set up an LTSP chroot environment on the machine, to act as
- a thin client server.
+ Please choose whether you want to set up an LTSP chroot environment
+ on this machine, to act as a thin client server.

Avoid a too close dependency of the long description on the short one.

 
 Template: debian-installer/ltsp-client-builder/title
 Type: text
@@ -22,14 +22,15 @@
  this option is meant to be used with debconf preseeding.
 
 Template: ltsp-client-builder/dhcp-manual
-Type: note
-_Description: No Interface for LTSP dhcpd configuration found
- There are no free interfaces for usage with the LTSP Server. Please configure the file /etc/ltsp/dhcpd.conf 
- manually to point to a valid static interface after the installation finished.
+Type: error
+_Description: No interface for LTSP dhcpd configuration
+ There are no free interfaces for usage with the LTSP server. Please
+ manually configure the /etc/ltsp/dhcpd.conf file to point to a valid
+ static interface after the installation has completed.

Avoid a half-sentence in the short description

Minor rewording. Hope this is correct use of tense.

 
 Template: ltsp-client-builder/dhcp-interface
 Type: select
 Choices: ${choices}
 _Description: Interface for the thin client network:
- There were multiple spare interfaces found in this system.
- 
+ Please choose, among the multiple spare interfaces this system has, which
+ one should be used for the thin client.

Avoid assuming that the long description is displayed *before* the
short one.


--- ltsp.old/debian/ltsp-client-core.templates	2007-06-21 10:27:51.637725911 +0200
+++ ltsp/debian/ltsp-client-core.templates	2007-06-28 07:48:38.348317578 +0200
@@ -1,7 +1,8 @@
 Template: ltsp-client/abort-installation
 Type: error
 _Description: Installation aborted 
- ltsp-client cannot be installed in a regular machine. This package provides 
- the basic structure for a LTSP terminal.
+ The ltsp-client package cannot be installed in a regular
+ machine. This package provides the basic structure for a LTSP
+ terminal.

Avoid a leading lowercase letter


  . 
  Please read the package description to understand what it means.
--- ltsp.old/debian/control	2007-06-21 10:27:51.637725911 +0200
+++ ltsp/debian/control	2007-06-28 07:52:31.336760011 +0200
@@ -13,17 +13,21 @@
 Conflicts: ltsp-utils
 Replaces: ltsp-utils
 Architecture: all
-Description: Basic LTSP server environment
+Description: basic LTSP server environment
  This is the basic environment depending on an external DHCP server to
  point the clients to the LTSP server.
+ .
+ LTSP stands for 'Linux Thin Server Project'.

The point of a package description is *alos* to explain acronyms..:-)

 
 Package: ltsp-server-standalone
 Depends: ltsp-server, dhcp3-server, libasound2-plugins, ltspfs, openssh-server, nbd-server, pulseaudio-esound-compat | esound-clients | nas-bin, xbase-clients
 Recommends: 
 Architecture: all
-Description: Complete LTSP server environment
+Description: complete LTSP server environment

No leading capital

@@ -41,7 +47,9 @@
 Suggests: cryptsetup, joystick [alpha amd64 arm i386 ia64]
 Architecture: all
 Description: LTSP client environment
- The scripts needed to configure and boot an LTSP client.
+ This package provides the scripts needed to configure and boot an LTSP client.

Make a complete sentence.


-------------- next part --------------
Template: ltsp-client-builder/run
Type: boolean
Default: false
_Description: Set up an LTSP chroot environment?
 Please choose whether you want to set up an LTSP chroot environment
 on this machine, to act as a thin client server.

Template: debian-installer/ltsp-client-builder/title
Type: text
# Item in the main menu to select this package
_Description: Build LTSP chroot

Template: ltsp-client-builder/progress
Type: text
_Description: Building LTSP chroot...

Template: ltsp-client-builder/build-client-opts
Type: string
Default: --mirror file:///cdrom --security-mirror none
# Only used for preseeding arguments to ltsp-client-builder.
Description: arguments for ltsp-build-client:
 this option is meant to be used with debconf preseeding.

Template: ltsp-client-builder/dhcp-manual
Type: error
_Description: No interface for LTSP dhcpd configuration
 There are no free interfaces for usage with the LTSP server. Please
 manually configure the /etc/ltsp/dhcpd.conf file to point to a valid
 static interface after the installation has completed.

Template: ltsp-client-builder/dhcp-interface
Type: select
Choices: ${choices}
_Description: Interface for the thin client network:
 Please choose, among the multiple spare interfaces this system has, which
 one should be used for the thin client.
-------------- next part --------------
Template: ltsp-client/abort-installation
Type: error
_Description: Installation aborted 
 The ltsp-client package cannot be installed in a regular
 machine. This package provides the basic structure for a LTSP
 terminal.
 . 
 Please read the package description to understand what it means.
-------------- next part --------------
--- ../ltsp.old/debian/ltsp-client-builder.templates	2007-06-21 10:27:51.637725911 +0200
+++ debian/ltsp-client-builder.templates	2007-06-28 07:51:07.840901865 +0200
@@ -2,8 +2,8 @@
 Type: boolean
 Default: false
 _Description: Set up an LTSP chroot environment?
- This will set up an LTSP chroot environment on the machine, to act as
- a thin client server.
+ Please choose whether you want to set up an LTSP chroot environment
+ on this machine, to act as a thin client server.
 
 Template: debian-installer/ltsp-client-builder/title
 Type: text
@@ -22,14 +22,15 @@
  this option is meant to be used with debconf preseeding.
 
 Template: ltsp-client-builder/dhcp-manual
-Type: note
-_Description: No Interface for LTSP dhcpd configuration found
- There are no free interfaces for usage with the LTSP Server. Please configure the file /etc/ltsp/dhcpd.conf 
- manually to point to a valid static interface after the installation finished.
+Type: error
+_Description: No interface for LTSP dhcpd configuration
+ There are no free interfaces for usage with the LTSP server. Please
+ manually configure the /etc/ltsp/dhcpd.conf file to point to a valid
+ static interface after the installation has completed.
 
 Template: ltsp-client-builder/dhcp-interface
 Type: select
 Choices: ${choices}
 _Description: Interface for the thin client network:
- There were multiple spare interfaces found in this system.
- 
+ Please choose, among the multiple spare interfaces this system has, which
+ one should be used for the thin client.
--- ../ltsp.old/debian/ltsp-client-core.templates	2007-06-21 10:27:51.637725911 +0200
+++ debian/ltsp-client-core.templates	2007-06-28 07:48:38.348317578 +0200
@@ -1,7 +1,8 @@
 Template: ltsp-client/abort-installation
 Type: error
 _Description: Installation aborted 
- ltsp-client cannot be installed in a regular machine. This package provides 
- the basic structure for a LTSP terminal.
+ The ltsp-client package cannot be installed in a regular
+ machine. This package provides the basic structure for a LTSP
+ terminal.
  . 
  Please read the package description to understand what it means.
--- ../ltsp.old/debian/control	2007-06-21 10:27:51.637725911 +0200
+++ debian/control	2007-06-28 07:52:31.336760011 +0200
@@ -13,17 +13,21 @@
 Conflicts: ltsp-utils
 Replaces: ltsp-utils
 Architecture: all
-Description: Basic LTSP server environment
+Description: basic LTSP server environment
  This is the basic environment depending on an external DHCP server to
  point the clients to the LTSP server.
+ .
+ LTSP stands for 'Linux Thin Server Project'.
 
 Package: ltsp-server-standalone
 Depends: ltsp-server, dhcp3-server, libasound2-plugins, ltspfs, openssh-server, nbd-server, pulseaudio-esound-compat | esound-clients | nas-bin, xbase-clients
 Recommends: 
 Architecture: all
-Description: Complete LTSP server environment
+Description: complete LTSP server environment
  This is the complete environment including a DHCP server to bootstrap
  the clients.
+ .
+ LTSP stands for 'Linux Thin Server Project'.
  
 Package: ltsp-client-core
 Pre-Depends: debconf (>= 0.5) | debconf-2.0
@@ -34,6 +38,8 @@
  .
  DO NOT install this package on a regular machine, it is intended only
  for installation inside a LTSP client filesystem.
+ .
+ LTSP stands for 'Linux Thin Server Project'.
 
 Package: ltsp-client
 Depends: ltsp-client-core, ldm | sdm-terminal | x-display-manager, pulseaudio-esound-compat | esound | nas, ltspfsd, xorg, mdetect, xdebconfigurator, alsa-utils
@@ -41,7 +47,9 @@
 Suggests: cryptsetup, joystick [alpha amd64 arm i386 ia64]
 Architecture: all
 Description: LTSP client environment
- The scripts needed to configure and boot an LTSP client.
+ This package provides the scripts needed to configure and boot an LTSP client.
+ .
+ LTSP stands for 'Linux Thin Server Project'.
 
 Package: ldm
 Depends: openssh-client | ssh, python, python-gtk2, python-gnome2, python-glade2, gtk2-engines-clearlooks, xserver-xorg | xserver, lsb-release
@@ -55,6 +63,8 @@
  .
  It was written to work with the LTSP project, but should work without
  LTSP as well.
+ .
+ LTSP stands for 'Linux Thin Server Project'.
 
 Package: ltsp-client-builder
 Section: debian-installer
@@ -62,6 +72,8 @@
 Architecture: all
 Depends: ${misc:Depends}, ${shlibs:Depends}, kbd-chooser, pkgsel
 XB-Installer-Menu-Item: 7000
-Description: Build an LTSP environment in the installer target
+Description: build an LTSP environment in the installer target
  This udeb bootstraps the LTSP client chroot in the installer target 
  while the cdrom is still mounted.
+ .
+ LTSP stands for 'Linux Thin Server Project'.
-------------- next part --------------
Source: ltsp
Section: misc
Priority: extra
Maintainer: LTSP Debian/Ubuntu Maintainers <pkg-ltsp-devel at lists.alioth.debian.org>
Uploaders: Matt Zimmerman <mdz at debian.org>, Carlos Laviola <claviola at debian.org>, Michael Vogt <mvo at debian.org>, Oliver Grawert <ogra at ubuntu.com>, Petter Reinholdtsen <pere at debian.org>, Gustavo Franco <stratus at debian.org>, Vagrant Cascadian <vagrant at freegeek.org>, Otavio Salvador <otavio at debian.org>
Build-Depends: debhelper (>= 4), flex, bison, libpopt-dev, po-debconf
Standards-Version: 3.7.2

Package: ltsp-server
Depends: ${misc:Depends}, debootstrap, nfs-kernel-server, lsb-release, tftpd-hpa | atftpd, openssh-client | ssh, iproute, debconf-utils, python (>= 2.4), openbsd-inetd | inet-superserver, update-inetd, tcpd, gettext-base, nbd-server
Recommends: openssh-server | ssh
Suggests: dhcp3-server, sdm, audiooss
Conflicts: ltsp-utils
Replaces: ltsp-utils
Architecture: all
Description: basic LTSP server environment
 This is the basic environment depending on an external DHCP server to
 point the clients to the LTSP server.
 .
 LTSP stands for 'Linux Thin Server Project'.

Package: ltsp-server-standalone
Depends: ltsp-server, dhcp3-server, libasound2-plugins, ltspfs, openssh-server, nbd-server, pulseaudio-esound-compat | esound-clients | nas-bin, xbase-clients
Recommends: 
Architecture: all
Description: complete LTSP server environment
 This is the complete environment including a DHCP server to bootstrap
 the clients.
 .
 LTSP stands for 'Linux Thin Server Project'.
 
Package: ltsp-client-core
Pre-Depends: debconf (>= 0.5) | debconf-2.0
Depends: lsb-base, nbd-client, initramfs-tools (>= 0.11), syslinux [i386 amd64], mknbi[i386] | yaboot[powerpc] | aboot[alpha] | sparc-utils[sparc], lsb-release, kbd | console-tools, python, discover1, xresprobe
Architecture: any
Description: LTSP client environment
 The scripts needed to configure and boot an LTSP client.
 .
 DO NOT install this package on a regular machine, it is intended only
 for installation inside a LTSP client filesystem.
 .
 LTSP stands for 'Linux Thin Server Project'.

Package: ltsp-client
Depends: ltsp-client-core, ldm | sdm-terminal | x-display-manager, pulseaudio-esound-compat | esound | nas, ltspfsd, xorg, mdetect, xdebconfigurator, alsa-utils
Recommends: 
Suggests: cryptsetup, joystick [alpha amd64 arm i386 ia64]
Architecture: all
Description: LTSP client environment
 This package provides the scripts needed to configure and boot an LTSP client.
 .
 LTSP stands for 'Linux Thin Server Project'.

Package: ldm
Depends: openssh-client | ssh, python, python-gtk2, python-gnome2, python-glade2, gtk2-engines-clearlooks, xserver-xorg | xserver, lsb-release
Architecture: all
Description: LTSP display manager
 ldm is an X11 display manager similar to xdm, gdm and kdm, but unlike
 those it wraps the X11 traffic within an ssh tunnel to provide a
 secure login mechanism for remote X sessions.  ldm provides access
 only through SSH, not locally. It is technically possible to use ldm
 to connect to the same host, but probably a waste of CPU power.
 .
 It was written to work with the LTSP project, but should work without
 LTSP as well.
 .
 LTSP stands for 'Linux Thin Server Project'.

Package: ltsp-client-builder
Section: debian-installer
XC-Package-Type: udeb
Architecture: all
Depends: ${misc:Depends}, ${shlibs:Depends}, kbd-chooser, pkgsel
XB-Installer-Menu-Item: 7000
Description: build an LTSP environment in the installer target
 This udeb bootstraps the LTSP client chroot in the installer target 
 while the cdrom is still mounted.
 .
 LTSP stands for 'Linux Thin Server Project'.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-ltsp-devel/attachments/20070707/bfd58dec/attachment.sig>


More information about the Pkg-ltsp-devel mailing list