[Pkg-ltsp-devel] please review LTSP debconf templates

[vagrant at freegeek.org]

On Sat, Oct 13, 2007 at 11:09:12AM +0100, Justin B Rye wrote:
> vagrant at freegeek.org wrote:
> > attached are the two relevent templates files.
> 
> Now I notice a couple more things that I should have fixed the last
> time it passed this way.
> 
> > Template: ltsp-client-builder/dhcp-interface
> > Type: select
> > Choices: ${choices}
> > _Description: Interface for the thin client network:
> >  Please choose, among the multiple spare interfaces this system has, which
> >  one should be used for the thin client.
> 
> Make that:
>    Please choose which of this system's multiple spare interfaces should be
>    used for the thin client.
> 
> > Template: ltsp-client/abort-installation
> > Type: error
> > _Description: Installation aborted
> >  The ltsp-client package cannot be installed in a regular
> >  machine. This package provides the basic structure for a LTSP
> >  terminal.
> >  . 
> >  Please read the package description to understand what it means.
> 
> That's *an* ell-ess-tee-pee terminal.  But while I'm rephrasing
> things, how about:
> 
>    The ltsp-client package provides the basic structure for an LTSP
>    terminal. It cannot be installed on a regular machine.
> 
> Patch attached.

is the following patch considered the final patch properly reviewed by
the debian-l10n-english team? as a maintainer, i will be happy to apply
it. let me know so i can proceed to ask for updated translations.

a related aside, is there a document for recommended procedure for
english reviews? as an ltsp maintainer, i would prefer a bug report
filed in the debian bts when the review is finished... but i don't know
what the standard or current operating practice is.

live well,
  vagrant

> --- ../ltsp.old/ltsp-client-builder.templates	2007-10-13 10:49:49.000000000 +0100
> +++ ltsp-client-builder.templates	2007-10-13 10:58:45.000000000 +0100
> @@ -21,11 +21,11 @@
>  
>  Template: ltsp-client-builder/progress
>  Type: text
> -_Description: Building thin client system ...
> +_Description: Building thin client system...
>  
>  Template: ltsp-client-builder/compress
>  Type: text
> -_Description: Compressing thin client image ...
> +_Description: Compressing thin client image...
>  
>  Template: ltsp-client-builder/build-client-opts
>  Type: string
> @@ -45,5 +45,5 @@
>  Type: select
>  Choices: ${choices}
>  _Description: Interface for the thin client network:
> - Please choose, among the multiple spare interfaces this system has, which
> - one should be used for the thin client.
> + Please choose which of this system's multiple spare interfaces should be
> + used for the thin client.
> --- ../ltsp.old/ltsp-client-core.templates	2007-10-13 10:49:50.000000000 +0100
> +++ ltsp-client-core.templates	2007-10-13 10:56:10.000000000 +0100
> @@ -10,8 +10,5 @@
>  Template: ltsp-client/abort-installation
>  Type: error
>  _Description: Installation aborted
> - The ltsp-client package cannot be installed in a regular
> - machine. This package provides the basic structure for a LTSP
> - terminal.
> - . 
> - Please read the package description to understand what it means.
> + The ltsp-client package provides the basic structure for an LTSP
> + terminal. It cannot be installed on a regular machine.