[Pkg-lustre-maintainers] Status of 1.6.2 packaging?

[Niklas Edmundsson]

On Wed, 19 Sep 2007, Patrick Winnertz wrote:

>> although I suspect there is some difference in some case. If there
>> isn't a very good reason for using binary:Version I would suggest
>> changing it to Source-Version for back-compatibility reasons.
> No, sorry
> We need binary:Version since without binary:Version this package is not
> binNMU save.

Aaaah, I see.

>> Building the thing then went fine. However, I have a few packaging
>> bugs to report:
>>
>> linux-patch-lustre should depend on dpatch. There are possibly similar
>> dependency issues with lustre-source (quilt/dpatch).
> Why? We don't use there dpatch at all. Only quilt. This works very fine in
> debian. :)

OK. I ran into a situation where the build failed with "dpatch: no 
such file or directory", so it's indeed needed.

>> lustre-source seems to install the modules to the wrong directory, ie.
>> if uname -r says 2.6.18-lustre-amd64-k8-smp the modules gets put in
>> /lib/modules/2.6.18 which isn't too bright.
> I'll look at this. But the last times i bulid a kernel the modules get
> installed in the correct location.

There's something fishy with this, since there are claims that lustre 
upstreams gets it right now...


I also discovered that a version-check for 2.6.15/2.6.16 in the 
upstream lustre source is still wrong. The issue is that they depend 
on checking the kernel version to determine whether a struct has 
changed, but the check is made using a heavily patched (ie. RH/Suse) 
kernel, so using Ubuntu (or vanilla) 2.6.15 the build fails.

The attached patch should fix this.

We're currently hammering our setup to see if things seems to work. 
Ubuntu LTS on all involved machines, Debian 2.6.18 lustre-patched 
kernel on servers, Ubuntu 2.6.15 LTS kernel with patchless client on 
the clients.


/Nikke
-- 
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
  Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se     |    nikke at hpc2n.umu.se
---------------------------------------------------------------------------
  Doing it the hard way is always easier.
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
-------------- next part --------------
Index: trunk/debian/patches/fix-2.6.15-versioncheck.dpatch
===================================================================
--- trunk/debian/patches/fix-2.6.15-versioncheck.dpatch	(revision 0)
+++ trunk/debian/patches/fix-2.6.15-versioncheck.dpatch	(revision 0)
@@ -0,0 +1,21 @@
+#! /bin/sh /usr/share/dpatch/dpatch-run
+## fix-2.6.15-versioncheck.dpatch by Niklas Edmundsson <Niklas.Edmundsson at hpc2n.umu.se>
+##
+## All lines beginning with `## DP:' are a description of the patch.
+## DP: Fix version-check for 2.6.15 ubuntu/vanilla kernel.
+## DP: Upstream check assumes RedHat patched kernel.
+
+ at DPATCH@
+
+diff lustre-1.6.2/lustre/include/linux/lustre_compat25.h lustre-1.6.2/lustre/include/linux/lustre_compat25.h
+--- lustre-1.6.2/lustre/include/linux/lustre_compat25.h	(revision 135)
++++ lustre-1.6.2/lustre/include/linux/lustre_compat25.h	(working copy)
+@@ -75,7 +75,7 @@
+ #define TRYLOCK_INODE_MUTEX(inode) (!down_trylock(&(inode)->i_sem))
+ #endif /* HAVE_INODE_I_MUTEX */
+ 
+-#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,15)
++#if LINUX_VERSION_CODE > KERNEL_VERSION(2,6,15)
+ #define d_child d_u.d_child
+ #define d_rcu d_u.d_rcu
+ #endif

Property changes on: trunk/debian/patches/fix-2.6.15-versioncheck.dpatch
___________________________________________________________________
Name: svn:executable
   + *

Index: trunk/debian/patches/00list
===================================================================
--- trunk/debian/patches/00list	(revision 344)
+++ trunk/debian/patches/00list	(working copy)
@@ -31,3 +31,5 @@
 
 #discuss needed
 #bug12644-fix-FIEMAP.dpatch
+
+fix-2.6.15-versioncheck.dpatch