Bug#856696: clvm: removing clvm modifies conffile /etc/lvm/lvm.conf

[Andreas Beckmann]

Package: clvm
Version: 2.02.168-1
Severity: serious
User: debian-qa at lists.debian.org
Usertags: piuparts

Hi,

during a test with piuparts I noticed your package modifies conffiles.
This is forbidden by the policy, see
https://www.debian.org/doc/debian-policy/ch-files.html#s-config-files

10.7.3: "[...] The easy way to achieve this behavior is to make the
configuration file a conffile. [...] This implies that the default
version will be part of the package distribution, and must not be
modified by the maintainer scripts during installation (or at any
other time)."

Note that once a package ships a modified version of that conffile,
dpkg will prompt the user for an action how to handle the upgrade of
this modified conffile (that was not modified by the user).

Further in 10.7.3: "[...] must not ask unnecessary questions
(particularly during upgrades) [...]"

If a configuration file is customized by a maintainer script after
having asked some debconf questions, it may not be marked as a
conffile. Instead a template could be installed in /usr/share and used
by the postinst script to fill in the custom values and create (or
update) the configuration file (preserving any user modifications!).
This file must be removed during postrm purge.
ucf(1) may help with these tasks.
See also https://wiki.debian.org/DpkgConffileHandling

In https://lists.debian.org/debian-devel/2012/09/msg00412.html and
followups it has been agreed that these bugs are to be filed with
severity serious.

debsums reports modification of the following files,
from the attached log (scroll to the bottom...):

  /etc/lvm/lvm.conf


there are whitespace changes in the file:

--- /etc/lvm/lvm.conf.001       2017-03-04 01:08:24.566741549 +0000
+++ /etc/lvm/lvm.conf   2017-03-04 01:11:40.735095076 +0000
@@ -756,7 +756,7 @@
        #     in use, for example a virtual machine image or a disk that is
        #     shared by a clustered machine.
        # 
-       locking_type = 1
+    locking_type = 1
 
        # Configuration option global/wait_for_locks.
        # When disabled, fail if a lock request would block.
@@ -925,7 +925,7 @@
        # are checked during pvscan --cache. To filter a device and prevent
        # scanning from the LVM system entirely, including lvmetad, use
        # devices/global_filter.
-       use_lvmetad = 1
+    use_lvmetad = 1
 
        # Configuration option global/lvmetad_update_wait_time.
        # The number of seconds a command will wait for lvmetad update to finish.


cheers,

Andreas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: clvm_2.02.168-1.log.gz
Type: application/gzip
Size: 8999 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-lvm-maintainers/attachments/20170304/a647da0c/attachment.bin>