[pkg-lxc-devel] syncing lxcfs from Debian to Ubuntu

[Evgeni Golov]

Hey,

On Thu, Oct 27, 2016 at 12:17:52PM -0400, Stéphane Graber wrote:
> > > > Hm?  I thought that '| cgroup-lite' was fine if cgroup-lite did not
> > > > exist?
> > > > 
> > > > (I'm showing my naivité I'm sure)
> > > 
> > > Not in Debian, at least [1].
> > > But jamessan in #debian-devel had a good idea.
> > > We could use ${lxcfs:Depends} in the control file and generate that var
> > > dynamically in d/rules, checking whether we build for Ubuntu or Debian
> > > (using dpkg-vendor / /usr/share/dpkg/vendor.mk).
> > > 
> > > How does that sound to you?
> > 
> > It's fine with me (we do that sort of thing in qemu), but when Stéphane
> > objected I thought it was about another problem he had with the synced
> > packaging.  Stéphane, do you have a problem with just dropping |
> > cgroup-lite from the dependencies for lxcfs?  I see we'd have to add
> > cgroupfs-mount to trusty-backports, but other than that it should be ok.
> 
> So with the ${lxcfs:Depends} trick, we could have:
> 
> Debian:
> 
>   systemd | cgroupfs-mount
> 
> Ubuntu:
> 
>   systemd | cgroup-lite | cgroupfs-mount
> 
> That will make sure things don't regress on our side.

Have a look at [1], which implements the above.
Untested on Ubuntu, though ;)

> I will look at killing cgroup-lite in favor of cgroupfs-mount in Ubuntu,
> but I'm reasonably sure that we have a few extra bits in our version of
> the script so want to make sure we favor it when it exists just so we
> don't regress.
> 
> 
> My plan is to basically do a diff of cgroup-lite and cgroupfs-mount,
> look for whatever extra bits we have, send those to Debian, once Debian
> has everything we need, I'll sync the package and turn cgroup-lite into
> a transitional package.
> 
> Then probably wait for the next Ubuntu release and kill cgroup-lite entirely.

That sounds like a sensible long-term plan. +1!

Greets
Evgeni

[1] https://anonscm.debian.org/cgit/pkg-lxc/lxcfs.git/commit/?id=abc51b7b3199201ee485751f16ff8b634ba6228d