[pkg-mad-maintainers] Patch to libid3tag0-dev for EasyH10
Kurt Roeckx
kurt at roeckx.be
Sun Aug 14 13:20:27 UTC 2005
On Sat, Aug 13, 2005 at 09:03:12PM +0200, Clément Stenac wrote:
> Hello,
>
> This is of course always possible but requires to modify the SONAME of
> the library, which will not match the upstream anymore. This is
> acceptable, but not really recommended.
Actually, just adding function doesn't require an soname change,
this is a backward comptabible API/ABI change, and just requires
us to bump the shlibs.
But I agree that we should try to get it merged upstream.
Also, it would be nice to know what the intended use of those 3
added functions are, maybe we can come up with a better/more
general solution to the problem, or some better way to do it.
It contains this change:
- file->path = path ? strdup(path) : 0;
+ if (path) {
+ file->path = (char *)malloc(strlen(path)+1);
+ strcpy(file->path, path);
+ } else {
+ file->path = 0;
+ }
I don't see why this is changed, both really should do the same.
There is an other change in it that might look like a bugfix, but
I'm not really sure about that.
Kurt
More information about the pkg-mad-maintainers
mailing list