[pkg-mad-maintainers] [daper@daper.net: libid3tag0: Some mp3 files can cause a segfault.]

[Kurt Roeckx]

On Fri, Jan 06, 2006 at 10:30:33PM +0100, Kurt Roeckx wrote:
> 
> There is no 12_endless_loop patch in the Debian package.  This
> seems to have been lost somewhere when we took over the package,
> and someone did a QA upload in the mean time.  I've tried to
> reproduce the bug from #304913 but it failed.  The patch for it
> also looks questionable.

It seems it's actually called 10_utf16 and not 12_endless_loop.
I also think the patch doesn't cover all cases it should.  There
basicly is a problem when the length is odd.  And the current
patch only covers the case where length is < 2 (0 or 1).

> > http://users.lin.one.pl/~daper/pub/libid3tag-debian-bug.mp3
> > 
> > (File was cut off to 16KB, but still shhows the bug). Tags are read
> > properly by libid3tag without any patches and by XMMS.
> 
> I can reproduce that problem, will look at it.

The patch looks good in any case, I'm just pondering if it should
continue or goto fail.


Kurt