[pkg-mad-maintainers] Bug#539871: libid3tag encoding patch update

[Andreas Henriksson]

Package: libid3tag
Version: 0.15.1b-10
Severity: important

Hector Santos found a problem with the current patch and seems to have
figured out a much better fix. See forwarded message below.

Regards,
Andreas Henriksson

----- Forwarded message from Hector Santos <hsantos at santronics.com> -----

Date: Fri, 24 Jul 2009 18:26:56 -0400
From: Hector Santos <hsantos at santronics.com>
To: andreas at fatal.se
Subject: libid3tag patch update
User-Agent: Thunderbird 2.0.0.0 (Windows/20070326)

Hello, I had a problem with a MP3 file using the libid3tag library and
after tracking it down, I looked for a current patch. I found yours:

http://patch-tracking.debian.net/patch/series/view/libid3tag/0.15.1b-10/11_unknown_encoding

This work, but it doesn't solve the issue of why it is reading the
TYER tags wrong.

The patch I have (which includes your changes) isL


    end = data + length;

+   length 4 is expected, if 5 then get encoding byte
+   encoding = 0;
+   if (length == 5) {
+       encoding = id3_parse_uint(&data, 1);
+   }
    string   = id3_parse_string(&data, end - data, encoding, 0);

    if (!string) {
        continue;
    }

    if (id3_ucs4_length(string) < 4) {
      free(string);
      continue;
    }

I am not an expert with this patch systems, so I hope you can update
the library for the community.

Thanks

-- 
Sincerely

Hector Santos
http://www.santronics.com



----- End forwarded message -----