Bug#374401: madwifi-source: including .svn dirs causes MODULE_VERSION() to be incorrect when subversion is not installed

[Kel Modderman]

Package: madwifi-source
Version: 0.svnr1644.0.9.0-2
Severity: normal

Due to http://madwifi.org/ticket/694, a svn checkout was used instead of
an exported source tree (or upstream supplied snapshot). This causes the
svnversion: Makefile target of madwifi to call svnversion (provided by
subversion) for the creation of a header who's content is used by
MODULE_VERSION(). When subversion is not installed on the host system
the following occurs:

~/src/modules/madwifi $ make
Checking requirements... ok.
Checking kernel configuration... ok.
/bin/sh: line 1: svnversion: command not found
make -C /lib/modules/2.6.17-kel-1/build SUBDIRS=/home/kel/src/modules/madwifi modules
make[1]: Entering directory `/home/kel/src/linux-2.6.17-kel-1'
  CC [M]  /home/kel/src/modules/madwifi/ath/ah_osdep.o
....

And the resulting modules have an incomplete version field in modinfo
output:

~/src/modules/madwifi $ find . -type f -name '*.ko' -exec modinfo {} \;
....
filename:       ./ath_rate/sample/ath_rate_sample.ko
author:         John Bicket
description:    SampleRate bit-rate selection algorithm for Atheros devices
version:        svn r
license:        Dual BSD/GPL
....

The version field should look like:

version:        svn r1644

Or in the case a stable release tarball is used:

version:        0.9.0

Solution:

In the case the package is based on an svn snapshot, the orig.tar.gz should
be taken from 

http://snapshots.madwifi.org/madwifi-ng/

This would ensure the end user gets the exact svn version of the
snapshot in the module's version printout (reducing confusion and
allowing upstream to debug reported problemswith greater confidence).

Or, in the case that the package is based on a stable release of
madwifi, the orig.tar.gz should be taken from the sourceforge download
service as described at

http://madwifi.org/wiki/UserDocs/GettingMadwifi#Downloadingstablereleases

#694 has been "fixed" upstream by falling back to the last stable
release version number in the case that the sources are pristine clean
(svn export or snapshot without SNAPSHOT file present). However, as
already stated, it is more useful to the upstream developers if the svn
revision is printed out in the case a user has a problem with an svn
snapshot and not a stable release.

Thanks, Kel.


-- System Information:
Debian Release: testing/unstable
  APT prefers experimental
  APT policy: (500, 'experimental'), (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.17-kel-1
Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8)

Versions of packages madwifi-source depends on:
ii  bzip2                         1.0.3-2    high-quality block-sorting file co
ii  debhelper                     5.0.37.1   helper programs for debian/rules
ii  module-assistant              0.10.4     tool to make module package creati

madwifi-source recommends no packages.

-- no debconf information