[Pkg-mailman-hackers] Bug#244673: Your Mailman Debian bug

[Bernhard Reiter]

On Mon, Dec 12, 2005 at 09:01:20PM +0100, Lionel Elie Mamane wrote:
> The promised interface is that it gets set to "yes", "From " mangling
> gets done. If you intend not to do "From " mangling, ever, it is a bit
> ... "deceitful" is much much too strong, but I can't find a good word
> now ... to take the argument in __init__. It would confuse a user and
> send him in fits of debugging of why this option doesn't work.

> > Note that you, in replacing maxheaderlen, will not fullfill the
> > promise of Generator __init_ interface anymore. (...)  

> Yes... Maybe I should move children_maxheaderlen last and rename
> toplevel_maxheaderlen to just "maxheaderlen", to stay more
> compatible.

I think both points are minor, 
as the real patch should be different anyway and fix the email module.
Thanks for actively revising my patch! Good work!

> > Note also that clone() now also does something different in a
> > subtile way in your patch
> 
> ? It still creates a new Mailman.Generator that will not fold
> headers. (Unless children_maxheaderlen is given a non-default value.)
> 
> > and depends on a Python version >2.2.2.
> 
> Ah? I tried to find the documentation of "email" on
> http://www.python.org/doc/2.1.3/lib/lib.html to see whether it could
> be avoided, but I can't find it. Do you have a pointer to it?

It think this was missconception on my part,
Python 2.2 just added the email class, 
and clone() seems to have come with python 2.2.2.
As far as I remember Mailman brought its own email package if you
haven't had this one already.

> >> Current OpenPGP implementations do 'From '-mangling themselves
> >> anyway before clearsigning. I dunno whether S/MIME implementations
> >> do, too.
> 
> > I do not know for sure either.  I would assume that any reasonable
> > OpenPGP or S/MIME implementation would not mangle the from before
> > signing.
> 
> PGP and GnuPG both do; GnuPG puts a "- " in front of "From " in the
> beginning of a line.

GnuPG itself is not an OpenPGP mail application,
I just tested mutt and Kmail and both encode the F in the body
with quoted-printable, a nice solution.

> > Otherwise it would be a "modification" of the message and the email
> > would contain something that the user did not write.
> 
> If they don't, the signature on the message will not verify (for same
> cases) for no good reason.

It will verify, because the receiving MUA should be able to know
when it read from an mbox or not. And the MTA's should not mangle.

> > It is a minor modification, but still it is a modification.  And
> > maildir system can save a "From " in the body without problems and
> > SMTP also has no problem.
> 
> Which doesn't mean that From-escaping doesn't happen some MTA's /
> LDA's are *very* eager and do it (nearly) all the time.

For an MTA I guess it would be a bug!
For Local Deliver Daemons, it probably depends.

Anyway, a resonable body encoding is the best way out.

	Bernhard
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-mailman-hackers/attachments/20051213/584d87cb/attachment.pgp