[From nobody Tue Jul 28 20:34:35 2009
Date: Mon, 27 Jul 2009 12:33:10 -0700
From: Mark Sapiro <mark@msapiro.net>
To: Tollef Fog Heen <tfheen@debian.org>
Subject: Debian Mailman Patch 30_pipermail_threads.patch breaks threading
Message-ID: <PC19220090727123310062590c6b1bb@msapiro>
MIME-Version: 1.0

The patch 30_pipermail_threads.patch for bug #167758
<http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=167758> causes
improper threading in pipermail archives.

For example, the post with subject "Twisted Trial" at
<http://twistedmatrix.com/pipermail/twisted-python/2009-June/thread.html#19859>
is indented below the previous post even though it did not reference
that post in any way.

Also, on the same index page, many posts are indented more than the
proper number of levels.

This can also be seen at
<http://twistedmatrix.com/pipermail/glyph-discuss/2009-May/thread.html>
where the only two posts are indented to the 'next' level even though
there are no posts at the 'higher' level.

See <http://allmydata.org/pipermail/tahoe-dev/2009-July/thread.html>
for another example of an improperly indented index.

I confirmed that 30_pipermail_threads.patch causes this by downloading
<http://allmydata.org/pipermail/tahoe-dev/2009-July.txt> and building
an archive from it with Mailman's bin/arch. The threading in the
resulting index looked correct. I then applied
30_pipermail_threads.patch and built the archive again with bin/arch
and the result was the incorrectly indented index.

I do see the problem in the original bug report, and in my test with a
simple 4-message input the patch does partially correct it, but even
there the subsequent messages are excessively indented.

When I get a chance, I'll try to come up with a proper fix.

-- 
Mark Sapiro <mark@msapiro.net>        The highway is for gamblers,
San Francisco Bay Area, California    better use your sense - B. Dylan



]