Przemyslaw Hawrylewicz Czarnowski: fix: memory leak in mdmon_pid()

Martin F. Krafft madduck at alioth.debian.org
Sun Aug 29 11:55:21 UTC 2010


Module: mdadm
Branch: upstream
Commit: 10013317ce51c6b619f9782b55e9b6b9f536f0a8
URL:    http://git.debian.org/?p=pkg-mdadm/mdadm.git;a=commit;h=10013317ce51c6b619f9782b55e9b6b9f536f0a8

Author: Przemyslaw Hawrylewicz Czarnowski <przemyslaw.hawrylewicz.czarnowski at intel.com>
Date:   Thu Apr 22 23:10:32 2010 +0100

fix: memory leak in mdmon_pid()

devnum2devname() returns pointer to memory allocated with strdup.
It must be released to prevent memory leak.

Signed-off-by: Przemyslaw Czarnowski <przemyslaw.hawrylewicz.czarnowski at intel.com>
Signed-off-by: Dan Williams <dan.j.williams at intel.com>

---

 util.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/util.c b/util.c
index 25f1e56..8315200 100644
--- a/util.c
+++ b/util.c
@@ -1532,7 +1532,11 @@ int mdmon_pid(int devnum)
 	char pid[10];
 	int fd;
 	int n;
-	sprintf(path, "%s/%s.pid", pid_dir, devnum2devname(devnum));
+	char *devname = devnum2devname(devnum);
+
+	sprintf(path, "%s/%s.pid", pid_dir, devname);
+	free(devname);
+
 	fd = open(path, O_RDONLY | O_NOATIME, 0);
 
 	if (fd < 0)




More information about the pkg-mdadm-commits mailing list