[Pkg-mediawiki-devel] mediawiki_1.19.1-2~exp2_i386.changes ACCEPTED into experimental

[Platonides]

On Wed, Aug 8, 2012 at 2:10 PM, Thorsten Glaser <t.glaser at tarent.de> wrote:
> On Tue, 7 Aug 2012, Platonides wrote:
>
>> You haven't opened a bug upstream, and not even provided the error
>> message you're "fixing".
>
> Yes, because the time wasn’t right for it yet to be fed
> to upstream because I’ve not collected enough information
> on that and have bigger things to experiment.

Just a note "I'm seeing this message 'Foozoid not full' that I was
told by some MW developers that it should never happen" would have
been a step in the right direction, even if follow-up was slow. Or
noting on this list that you had to patch it again, in that thread
where we said it wasn't.

> Why don’t you go review the other patches instead?
>
> bye,
> //mirabilos

I have inspected the list of patches at
http://patch-tracker.debian.org/package/mediawiki/1:1.19.1-2~exp3
That was the worst patch of them.
Going into detail:
- mimetypes.patch: I had already acknowledged it
- suppress_warnings.patch: Wrong by the addition of that
$wf__warnings_suppressed variable and wrong since no warning should be
shown there.
- fix_invalid_sql.patch: I stand with my analisis (forwarded two
months ago to this list) about why it isn't needed.
- fix_invalid_xhtml.patch: I didn't look too much into it, but seems
to fix actual xhtml problems. They should go upstream, but apparently
ok.
- fix_warnings.patch Fixes two different issues. The first one looks
valid, the second one is another error suppresion in a line which
should never show a message.