[Pkg-mediawiki-devel] Skins

[Thorsten Glaser]

On Tue, 3 Jul 2012, Daniel Friesen wrote:

> > • put some stuff before </title> after what’s normally written there

> Could you clarify what you want to add.
> The title is controllable in OutputPage so if you want to add some text
> to the title it should be possible.

Hm, okay. Basically, append ": ".$project->getPublicName() to the
<title> content, where $project is determined by some other code
already added.

> > • call a FusionForge function that displays the needed CSS for that
> >   (which in turn echo’s stuff that can be gotten by an API call, but
> >   also calls a plugin hook; the FF plugin API is totally misdesigned
> >   as the hooks are expected to echo stuff when written, instead of
> >   adding content to some variable that can be echo’d when needed)

> Without seeing what's outputted I'm not sure whether you should be using
> output buffering and which of addInlineStyle or addHeadItem you should use.

Well, the problem is, plugins can add *anything*. A naïve implementation
would just say we skip the plugin call for MW. That _could_ work.

> > • then, there's a patch that prevents MW from echoing <ul></ul> as
> >   that’s invalid XHTML, no idea if it’s still needed

> You're not trying to make your own skin?

No, just adapt MonoBook.

> Do you have a good good reason for XHTML to be your target?

Of course – the entire site uses XHTML 1.0 Transitional + RDFa 1.0,
and we chose XHTML 1.0 Transitional mostly because Mediawiki uses it…

> anymore. If you really need XML's extensibility there's XHTML5.

No, I’m not going to write *another* DTD, especially not for a moving
target, so it’s going to be 1.0 Transitional, or 1.1.

> > • change $footerlinks

> Naturally, modify $this->data['footerlinks'] from the *Template class.

OK, thanks.

> Though, the sane person would use SkinTemplateOutputPageBeforeExec and
> $tpl so that the modifications show up in all skins.

Well yes, but the FF integration (as it was handed to me) is like so
that it takes the MonoBook theme and manipulates it with the *forge
stuff.

> MediaWiki uses HTML5 going forwards. A lot of these 'bugs' look like
> you're erroneously leaving $wgHtml5 on and expecting it to output XHTML.

Ah, ok, that’s new. I’ll have a look into that, then. Like I said,
I wasn’t got very far in the patchwork yet…

bye,
//mirabilos
-- 
tarent solutions GmbH
Rochusstraße 2-4, D-53123 Bonn • http://www.tarent.de/
Tel: +49 228 54881-393 • Fax: +49 228 54881-314
HRB AG Bonn 5168 • USt-ID (VAT): DE122264941
Geschäftsführer: Boris Esser, Sebastian Mancke