[Pkg-mediawiki-devel] Fwd: Re: MediaWiki patches in Debian.

[Thorsten Glaser]

On Mon, 11 Jun 2012, Platonides wrote:

> >> +  * debian/patches/tarent.patch: new
> >> +    - includes/specials/SpecialAllpages.php:
> >> +      raise $maxPerPage, $maxLineCount
> 
> With a significant number of subpages available, this patch would
> allow to DoS a wiki with simple F5 being constantly pressed.

DoS is doable much more easily, so that’s no concern here,
but ok, then this is not upstreamable.

> >> +    - includes/DefaultSettings.php: add webdavs:// and file: support
> 
> Apparently, NEVER EDIT THIS FILE at the top of DefaultSettings is not
> enough? All such changes kill people's ability to painlessly switch to
> tarball

These are the local patches I added in our company’s APT repository,
where “people” means “the sysadmins”, and that’s, in the case of
wikis, me. So this is no point.

Also, a packager is bound to change files. Even if this were not a
local patch, I’d say, “so what? only packages are supported”. (But
please, let’s not go there. I just wanted to present the few local
changes I have for possible inclusion.)

> give them. Or if packages are broken.

Fix the packages, then.

> Also, I strongly doubt about these protocols' support across different
> browsers and platforms (especially file:), which means more nice ways
> to shoot yourself on the foot.

Konqueror (standard browser on KDE environments) supports them, and
our document management software is usable best via WebDAV. This is
a case of “Wikipedia” thinking vs. “Wiki used inside a specific en‐
vironment, such as a company” thinking. And if one of these links
does not work for a user, that does not matter at all, either. The
important thing here is that it works for most, and that it should,
must, be included.

> >> +  * debian/control: prefer PostgreSQL over MySQL in Depends/Recommends
> 
> PG is currently third DB in terms on MW support, significant number of
> extensions don't support it. If we recommend MySQL for MW, pretty

MySQL is not a database, and the MW installations in FusionForge use
the same database as the forge itself, just a different schema (one
per project). Why do you try to force your limited world view on
everyone?

Honestly, if MW does not work with PostgreSQL, either that’s going
to be fixed or MW is abandoned.

> > maxPerPage and maxLineCount by two orders of magnitude?  Is there any
> > benefit to showing 30,000 pages on an index sub-page?
> 
> Because someone wanted it and haven't thought about performance.

See my other reply for VALID reasons. Performance is impossible
with a PHP web application, anyway, already. Again, your reply
shows trying to force your limited world view upon everyone. I
personally don’t mix well with that (strictly not speaking for
FF, Debian, or my employer).

bye,
//mirabilos
-- 
tarent solutions GmbH
Rochusstraße 2-4, D-53123 Bonn • http://www.tarent.de/
Tel: +49 228 54881-393 • Fax: +49 228 54881-314
HRB AG Bonn 5168 • USt-ID (VAT): DE122264941
Geschäftsführer: Boris Esser, Sebastian Mancke