[Pkg-mlmmj-devel] Bug#519931: sends welcome E-mail when 'submod' is enabled

[Alexander Zangerl]

Package: mlmmj
Severity: normal
Tags: patch

looks like the original submitter never "got around" to a patch,
and the problem is still present in version 1.2.17-2.
recently i've run into the same (two) problems and so i've created 
a patch fixing them; would you please forward the patch upstream, too?

let's quickly recap the issues (this bug report is 2 years old) and 
my solutions:

* first, the cmdline mlmmj-sub command behaves badly when submod is on: it 
sends a "please wait" mail to the email in question (undesirable if we're
subscribing somebody in an automated fashion) and a "sub mod required" to 
the admin - and then all progress stalls until the admin responds to the 
sub mod email. this is bad because it makes automating subscriptions
via the cmdline tool impossible.

solution: i added the -X option to mlmmj-sub which disables submod for 
this run of mlmmj-sub. so, with -X given (by a human admin) mlmmj-sub lets
you subscribe somebody on the go. without -X you geht the normal behaviour 
just like before. i've updated the manpage, too.

* second, when subscriptions are handled via email, one cannot
switch off the welcome/goodbye emails that the subscriber receives.
(on the command line mlmmj-sub/unsub can be told not to send greetings by
leaving out the -c option.) 

solution: i've added a boolean tunable called nogreetings (plus docs) which,
when set and only if nosubconfirm is on as well, prevents the welcome/goodbye
messages. why did i decide to make this conditional on nosubconfirm?
rule of least surprise. without nosubconfirm the subscriber has to go 
through challenge/confirmation anyway, so first having them jump through 
these hoops and then not telling them about the success of the procedure 
seems silly. 

note: nogreetings doesn't affect submod and its "please wait" mail - i'm 
undecided as to whether it should or not.

regards
az
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 10_submod_cmdline.dpatch
Type: text/x-shellscript
Size: 9266 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-mlmmj-devel/attachments/20110413/f48e0263/attachment.bin>