[Pkg-mol-devel] change to ablk.c in 0.9.71_pre9 causes hang during early boot

[Gaudenz Steinlin]

Hi Joseph

The change below to ablk.c breaks MOL on OS X 10.4 for me. It hangs
during early boot with 

ablk iofunc: Bad address
ABlk engine error

Without this change mol 0.9.71_pre9 works without any problem.

Gaudenz

--- mol-0.9.71_pre8/src/drivers/disk/ablk.c     2005-10-10 03:22:48.000000000 +0200
+++ mol-0.9.71_pre9/src/drivers/disk/ablk.c     2006-09-05 05:18:11.000000000 +0200
@@ -115,6 +115,11 @@
        struct iovec vec[MAX_IOVEC];
        int n, count;

+       union {
+               void * v;
+               char * c;
+       } iovec_pun;
+
        n = count = 0;

        for( ;; ) {
@@ -162,7 +167,8 @@
                /* process scatter & gather bufs */
                if( (f & ABLK_SG_BUF) ) {
                        ablk_sg_t *p = (ablk_sg_t*)r;
-                       if( mphys_to_lvptr( p->buf, (char**)&vec[n].iov_base ) ) {
+                       iovec_pun.v = vec[n].iov_base;
+                       if( mphys_to_lvptr( p->buf, (char **)&iovec_pun.c ) ) {
                                printm("ablk: bogus sg-buf");
                                goto error;
                        }

On Wed, Jan 11, 2006 at 10:56:00AM -0500, Joseph Jezak wrote:
> Oh, I forgot one more thing.  I'm available on FreeNode as JoseJX if you would like to discuss anything further.  I also maintain a presence in 
> #MOL if you would like to ask MOL specific questions.
> 
> -Joe

-- 
Ever tried. Ever failed. No matter.
Try again. Fail again. Fail better.
~ Samuel Beckett ~