[Pkg-mozext-maintainers] RFS: addressbooks-sync-extension

[Benjamin Drung]

Am Freitag, den 03.12.2010, 13:35 +0100 schrieb Michael Fladischer:
> I am looking for a sponsor for my package "addressbooks-sync-extension".

IANADD yet, but here's my review:

1) The name: Do we need "-extension" in the source name? Is there an
other project which could conflict? What's with the upstream name
"addressbooks-synchronizer"?

2) Please add ${xpi:Depends} to Depends (refer to mozilla-devscripts
0.25)

3) Please mention the upstream names for Icedove and Iceape (at least in
the long description)

4) Some trailing spaces. Run 'wrap-and-sort' (from ubuntu-dev-tools in
experimental) to get rid of them.

5) Change "dh ... $@" to "dh $@ ..." in debian/rules (check debhelper
changelog)

6) Don't rely on the installation directory. The installation directory
depends on the version of mozilla-devscripts. You have to either specify
the location explicitly or (better) use install-xpi with
--remove-license-files.

-- 
Benjamin Drung
Ubuntu Developer (www.ubuntu.com) | Debian Maintainer (www.debian.org)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.alioth.debian.org/pipermail/pkg-mozext-maintainers/attachments/20101203/13465a11/attachment.pgp>