[Pkg-mozext-maintainers] RFS: addressbooks-sync-extension

Benjamin Drung bdrung at ubuntu.com
Fri Dec 3 16:02:11 UTC 2010


Am Freitag, den 03.12.2010, 16:46 +0100 schrieb Michael Fladischer:
> > 2) Please add ${xpi:Depends} to Depends (refer to mozilla-devscripts
> > 0.25)
> 
> Done.

This doesn't require a bump of the build dependency version, because the
change in 0.25 is upwards and downwards compatible. Look at [1] to
determine the minimal version. In your case it's mozilla-devscripts (>=
0.22~).

> > 3) Please mention the upstream names for Icedove and Iceape (at least in
> > the long description)
> 
> Done. But whom would this help? Ubuntu?

Yes and it help those people that need some time to map the Debian name
to the upstream name.

> > 4) Some trailing spaces. Run 'wrap-and-sort' (from ubuntu-dev-tools in
> > experimental) to get rid of them.
> 
> Done. Thanks for pointing out to this collection of nifty tools :-)

You're welcome. Once I have time, I will write blog entries about
wrap-and-sort, suspicious-source, and sponsor-patch.

> > 6) Don't rely on the installation directory. The installation directory
> > depends on the version of mozilla-devscripts. You have to either specify
> > the location explicitly or (better) use install-xpi with
> > --remove-license-files.
> 
> Done. [1] mentions the override_dh_auto_clean target. Is this necessary
> to override this one even when I specified "dh $@ --with xul-ext
> - --buildsystem=xul_ext"?

Nope. It's only required if you don't use xul_ext as build system.

[1] http://wiki.debian.org/mozilla-devscripts

-- 
Benjamin Drung
Ubuntu Developer (www.ubuntu.com) | Debian Maintainer (www.debian.org)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.alioth.debian.org/pipermail/pkg-mozext-maintainers/attachments/20101203/fe434307/attachment.pgp>


More information about the Pkg-mozext-maintainers mailing list