mozilla-* porter help needed for ARM

[Lennart Sorensen]

On Mon, Oct 03, 2005 at 01:27:37PM +0200, Alexander Sack wrote:
> before I start doing trial and error uploads, wasting lots of buildd
> time, could you help us and sort out what patches
> are needed in order to fix the FTBFS for mozilla-thunderbird
> (1.0.7-1) and mozilla-firefox (dito), please?

The solution in bug #325532 solved the build problem for nvu which had
the exact same error message.  You need to apply that patch including
the fix for the typo a bit further down in the message.  That should fix
mozilla.

Thunderbird has this problem in xptcinvoke_arm.cpp:

extern "C" {
    struct my_params_struct {
        nsISupports* that;
        PRUint32 Index;
        PRUint32 Count;
        nsXPTCVariant* params;
        PRUint32 fn_count;
        PRUint32 fn_copy;
    };
};   <- line 139: xptcinvoke_arm.cpp:139: error: extra ';'

This should either have the last ';' removed (it shouldn't be there)
or the block around the struct could go entirely since it has no real
purpose.

ie:

extern "C" {
    struct my_params_struct {
        nsISupports* that;
        PRUint32 Index;
        PRUint32 Count;
        nsXPTCVariant* params;
        PRUint32 fn_count;
        PRUint32 fn_copy;
    };
}

or

extern "C"
    struct my_params_struct {
        nsISupports* that;
        PRUint32 Index;
        PRUint32 Count;
        nsXPTCVariant* params;
        PRUint32 fn_count;
        PRUint32 fn_copy;
    };

Someone just made a typo it would appear and certainly didn't do even
the slightest checking to see if the syntax was still valid.

Isn't there a rule that you don't check things into cvs untile it at
least compiles?

Len Sorensen