New component in xulrunner

[Axel Beckert]

Hi Mike,

very interesting blog posts on Planet Debian. :-)

Will xulrunner 1.9.2 get a new binary package name, too, e.g.
xulrunner-1.9.2?

And shall I already add it as alternative dependency in the conkeror
package? At least some users in #conkeror says, conkeror already works
fine with 1.9.2.

On Thu, Feb 04, 2010 at 07:53:11AM +0100, Mike Hommey wrote:
[cmdline.preventDefault]
> Actually, this time the component does the right thing, except conkeror
> doesn't: the component sets cmdLine.preventDefault to true, in which
> case conkeror shouldn't be doing anything.

The following patch against conkeror seems to fix the problem for me
and doesn't seem to have any side effects on a first glance.

diff --git a/components/commandline.js b/components/commandline.js
index a77cb3f..5eed35d 100644
--- a/components/commandline.js
+++ b/components/commandline.js
@@ -13,7 +13,7 @@ Components.utils.import("resource://gre/modules/XPCOMUtils.jsm
 function cmdline() {}
 cmdline.prototype = {
     handle: function (cmdline) {
-        cmdline.preventDefault = true;
+        //cmdline.preventDefault = true;
         var conkeror = Cc["@conkeror.mozdev.org/application;1"].getService().wr
         conkeror.handle_command_line(cmdline);
     },
diff --git a/modules/command-line.js b/modules/command-line.js
index bc6b204..f2aa59d 100644
--- a/modules/command-line.js
+++ b/modules/command-line.js
@@ -116,7 +116,7 @@ function handle_command_line (cmdline) {
         for (let i = 0, clen = cmdline.length; i < clen; ++i)
             command_line.push(cmdline.getArgument(i));
 
-        var suppress_default = false;
+        var suppress_default = cmdline.preventDefault;
         var suppress_rc = false;
 
         var i = 0;

If upstream doesn't object, I'll commit that patch upstream and
therefore include it in the next conkeror upload.

Thanks for your help tracking this down.

		Regards, Axel
-- 
Axel Beckert - abe at deuxchevaux.org, abe at noone.org - http://noone.org/abe/