Bug#574833: libmozjs.so: missing symbols js_[AXY]

[Mike Hommey]

On Mon, Mar 22, 2010 at 03:51:28PM +0000, Darren Salt wrote:
> I demand that Mike Hommey may or may not have written...
> 
> [snip]
> > So, according to upstream, JS_ISSPACE and friends from jsstr.h are not
> > supposed to be public API at all, and should not have been used by gine
> > in the first place.
> 
> That's the thing. It doesn't.
> 
> However, I can't reproduce the problem, at least not trivially. (./configure
> was re-run; this probably has a lot to do with it.)
> 
> > Would you prefer that I reassign this bug to gxine or that I leave it
> > wontfix?
> 
> Neither: js_SkipWhiteSpace (in the same header file) uses JS_ISSPACE.

js_SkipWhiteSpace is not exported in 1.9.1. And I don't see it used in
gxine source.

> The private API should, IMO, be moved into separate header files, preferably
> named appropriately to indicate the private nature of the content; if js_A,
> js_X and js_Y are meant to be private then they should also be moved and
> renamed, but they still need to be exported so long as there's a public API
> function which causes them to be referenced.

I filed a bug upstream to stop installing headers that are not supposed
to be public.

Mike