Bug#871386: firefox: FTBFS: cc1: error: -Wformat-security ignored without -Wformat [-Werror=format-security]

[Lucas Nussbaum]

Source: firefox
Version: 54.0-2
Severity: serious
Tags: buster sid
User: debian-qa at lists.debian.org
Usertags: qa-ftbfs-20170807 qa-ftbfs
Justification: FTBFS on amd64

Hi,

During a rebuild of all packages in sid, your package failed to build on
amd64.

Relevant part (hopefully):
> /usr/bin/gcc -std=gnu99 -o nr_crypto.o -c -I/<<PKGBUILDDIR>>/build-browser/dist/system_wrappers -include /<<PKGBUILDDIR>>/config/gcc_hidden.h -DNDEBUG -DTRIMMED=1 -D_FILE_OFFSET_BITS=64 -DCHROMIUM_BUILD -DUSE_LIBJPEG_TURBO=1 -DUSE_NSS=1 -DENABLE_ONE_CLICK_SIGNIN -DGTK_DISABLE_SINGLE_INCLUDES=1 -D_ISOC99_SOURCE=1 -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_CONFIGURATION_POLICY -DENABLE_INPUT_SPEECH -DENABLE_NOTIFICATIONS -DENABLE_GPU=1 -DENABLE_EGLIMAGE=1 -DUSE_SKIA=1 -DENABLE_TASK_MANAGER=1 -DENABLE_WEB_INTENTS=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PROTECTOR_SERVICE=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_BACKGROUND=1 -DENABLE_AUTOMATION=1 -DENABLE_PRINTING=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DSANITY_CHECKS -DUSE_TURN -DUSE_ICE -DUSE_RFC_3489_BACKWARDS_COMPATIBLE -DUSE_STUND_0_96 -DUSE_STUN_PEDANTIC -DNR_SOCKET_IS_VOID_PTR -Drestrict= '-DR_PLATFORM_INT_TYPES=<stdint.h>' -DR_DEFINED_INT2=int16_t -DR_DEFINED_UINT2=uint16_t -DR_DEFINED_INT4=int32_t -DR_DEFINED_UINT4=uint32_t -DR_DEFINED_INT8=int64_t -DR_DEFINED_UINT8=uint64_t -DLINUX -DHAVE_LIBM=1 -DHAVE_STRDUP=1 -DHAVE_STRLCPY=1 -DHAVE_SYS_TIME_H=1 -DHAVE_VFPRINTF=1 -DNEW_STDIORETSIGTYPE=void -DTIME_WITH_SYS_TIME_H=1 '-D__UNUSED__=__attribute__((unused))' -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/<<PKGBUILDDIR>>/media/mtransport/third_party/nICEr -I/<<PKGBUILDDIR>>/build-browser/media/mtransport/third_party/nICEr/nicer_nicer -I/<<PKGBUILDDIR>>/media/mtransport/third_party/nrappkit/src/event -I/<<PKGBUILDDIR>>/media/mtransport/third_party/nrappkit/src/log -I/<<PKGBUILDDIR>>/media/mtransport/third_party/nrappkit/src/plugin -I/<<PKGBUILDDIR>>/media/mtransport/third_party/nrappkit/src/registry -I/<<PKGBUILDDIR>>/media/mtransport/third_party/nrappkit/src/share -I/<<PKGBUILDDIR>>/media/mtransport/third_party/nrappkit/src/stats -I/<<PKGBUILDDIR>>/media/mtransport/third_party/nrappkit/src/util -I/<<PKGBUILDDIR>>/media/mtransport/third_party/nrappkit/src/util/libekr -I/<<PKGBUILDDIR>>/media/mtransport/third_party/nrappkit/src/port/generic/include -I/<<PKGBUILDDIR>>/media/mtransport/third_party/nICEr/src/crypto -I/<<PKGBUILDDIR>>/media/mtransport/third_party/nICEr/src/ice -I/<<PKGBUILDDIR>>/media/mtransport/third_party/nICEr/src/net -I/<<PKGBUILDDIR>>/media/mtransport/third_party/nICEr/src/stun -I/<<PKGBUILDDIR>>/media/mtransport/third_party/nICEr/src/util -I/<<PKGBUILDDIR>>/media/mtransport/third_party/nrappkit/src/port/linux/include -I/<<PKGBUILDDIR>>/build-browser/ipc/ipdl/_ipdlheaders -I/<<PKGBUILDDIR>>/ipc/chromium/src -I/<<PKGBUILDDIR>>/ipc/glue -I/<<PKGBUILDDIR>>/build-browser/dist/include    -fPIC  -include /<<PKGBUILDDIR>>/build-browser/mozilla-config.h -DMOZILLA_CLIENT -MD -MP -MF .deps/nr_crypto.o.pp -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wempty-body -Wignored-qualifiers -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -fstack-protector-strong -Wformat -Werror=format-security -fno-schedule-insns2 -fno-lifetime-dse -fno-delete-null-pointer-checks -fno-strict-aliasing -ffunction-sections -fdata-sections -fno-math-errno -pthread -pipe  -g -freorder-blocks -Os -fomit-frame-pointer -Wall -Wno-parentheses -Wno-strict-prototypes -Wmissing-prototypes -Wno-format  /<<PKGBUILDDIR>>/media/mtransport/third_party/nICEr/src/crypto/nr_crypto.c
> cc1: error: -Wformat-security ignored without -Wformat [-Werror=format-security]
> cc1: some warnings being treated as errors
> /<<PKGBUILDDIR>>/config/rules.mk:886: recipe for target 'nr_crypto.o' failed
> make[6]: *** [nr_crypto.o] Error 1

The full build log is available from:
   http://aws-logs.debian.net/2017/08/07/firefox_54.0-2_unstable.log

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

About the archive rebuild: The rebuild was done on EC2 VM instances from
Amazon Web Services, using a clean, minimal and up-to-date chroot. Every
failed build was retried once to eliminate random failures.