[Pkg-mpd-maintainers] Bug#853561: mpd: ftbfs with GCC-7

[Matthias Klose]

Package: src:mpd
Version: 0.19.21-1
Severity: normal
Tags: sid buster
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-7

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-7/g++-7, but succeeds to build with gcc-6/g++-6. The
severity of this report may be raised before the buster release.
There is no need to fix this issue in time for the stretch release.

The full build log can be found at:
http://people.debian.org/~doko/logs/gcc7-20170126/mpd_0.19.21-1_unstable_gcc7.log
The last lines of the build log are at the end of this report.

To build with GCC 7, either set CC=gcc-7 CXX=g++-7 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-7/porting_to.html

[...]
g++ -pthread -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -fvisibility=hidden -fno-threadsafe-statics -fmerge-all-constants -fno-exceptions -fno-rtti -ffast-math -ftree-vectorize -ffunction-sections -fdata-sections -Wall -Wextra -Wmissing-declarations -Wshadow -Wpointer-arith -Wcast-qual -Wwrite-strings -Wsign-compare  -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -Wl,--gc-sections -o test/run_avahi src/test_run_avahi-Log.o src/test_run_avahi-LogBackend.o src/zeroconf/test_run_avahi-ZeroconfAvahi.o src/zeroconf/test_run_avahi-AvahiPoll.o test/test_run_avahi-ShutdownHandler.o test/test_run_avahi-run_avahi.o libevent.a libsystem.a libutil.a -lgthread-2.0 -pthread -lglib-2.0 -lavahi-common -lavahi-client -ldbus-1 -lm 
g++ -pthread -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -fvisibility=hidden -fno-threadsafe-statics -fmerge-all-constants -fno-exceptions -fno-rtti -ffast-math -ftree-vectorize -ffunction-sections -fdata-sections -Wall -Wextra -Wmissing-declarations -Wshadow -Wpointer-arith -Wcast-qual -Wwrite-strings -Wsign-compare  -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -Wl,--gc-sections -o src/pcm/dsd2pcm/dsd2pcm src/pcm/dsd2pcm/dsd2pcm.o src/pcm/dsd2pcm/noiseshape.o src/pcm/dsd2pcm/main.o libutil.a -lm 
g++ -pthread -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -fvisibility=hidden -fno-threadsafe-statics -fmerge-all-constants -fno-exceptions -fno-rtti -ffast-math -ftree-vectorize -ffunction-sections -fdata-sections -Wall -Wextra -Wmissing-declarations -Wshadow -Wpointer-arith -Wcast-qual -Wwrite-strings -Wsign-compare  -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -Wl,--gc-sections -o test/run_inotify test/run_inotify.o test/ShutdownHandler.o src/Log.o src/LogBackend.o src/db/update/InotifyDomain.o src/db/update/InotifySource.o libevent.a libsystem.a libutil.a -lgthread-2.0 -pthread -lglib-2.0 -lm 
g++ -pthread -Wno-error=deprecated-declarations -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -fvisibility=hidden -fno-threadsafe-statics -fmerge-all-constants -fno-exceptions -fno-rtti -ffast-math -ftree-vectorize -ffunction-sections -fdata-sections -Wall -Wextra -Wmissing-declarations -Wshadow -Wpointer-arith -Wcast-qual -Wwrite-strings -Wsign-compare  -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -Wl,--gc-sections -o test/test_icy_parser src/test_test_icy_parser-Log.o src/test_test_icy_parser-LogBackend.o test/test_test_icy_parser-test_icy_parser.o libtag.a libutil.a -lgthread-2.0 -pthread -lglib-2.0 -lcppunit -lm 
g++ -pthread -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -fvisibility=hidden -fno-threadsafe-statics -fmerge-all-constants -fno-exceptions -fno-rtti -ffast-math -ftree-vectorize -ffunction-sections -fdata-sections -Wall -Wextra -Wmissing-declarations -Wshadow -Wpointer-arith -Wcast-qual -Wwrite-strings -Wsign-compare  -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -Wl,--gc-sections -o test/dump_rva2 src/Log.o src/LogBackend.o test/dump_rva2.o libtag.a -lid3tag -lz libutil.a -lgthread-2.0 -pthread -lglib-2.0 -lm 
ranlib libmixer_plugins.a
ranlib libfilter_plugins.a
In file included from src/archive/plugins/Iso9660ArchivePlugin.cxx:36:0:
/usr/include/cdio/iso9660.h:277:45: error: flexible array member 'iso9660_dir_s::filename' not at end of 'struct iso9660_pvd_s'
   char             filename[EMPTY_ARRAY_SIZE];
                                             ^
/usr/include/cdio/iso9660.h:310:20: note: next member 'char iso9660_pvd_s::root_directory_filename' declared here
   char             root_directory_filename;      /**< Is '\\0' or root
                    ^~~~~~~~~~~~~~~~~~~~~~~
/usr/include/cdio/iso9660.h:283:8: note: in the definition of 'struct iso9660_pvd_s'
 struct iso9660_pvd_s {
        ^~~~~~~~~~~~~
/usr/include/cdio/iso9660.h:277:45: error: flexible array member 'iso9660_dir_s::filename' not at end of 'struct iso9660_svd_s'
   char             filename[EMPTY_ARRAY_SIZE];
                                             ^
/usr/include/cdio/iso9660.h:424:20: note: next member 'char iso9660_svd_s::root_directory_filename' declared here
   char             root_directory_filename;      /**< Is '\\0' or root
                    ^~~~~~~~~~~~~~~~~~~~~~~
/usr/include/cdio/iso9660.h:392:8: note: in the definition of 'struct iso9660_svd_s'
 struct iso9660_svd_s {
        ^~~~~~~~~~~~~
g++ -pthread -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -fvisibility=hidden -fno-threadsafe-statics -fmerge-all-constants -fno-exceptions -fno-rtti -ffast-math -ftree-vectorize -ffunction-sections -fdata-sections -Wall -Wextra -Wmissing-declarations -Wshadow -Wpointer-arith -Wcast-qual -Wwrite-strings -Wsign-compare  -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -Wl,--gc-sections -o test/run_gzip test/run_gzip.o libutil.a libfs.a -lz -lm 
g++ -pthread -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -fvisibility=hidden -fno-threadsafe-statics -fmerge-all-constants -fno-exceptions -fno-rtti -ffast-math -ftree-vectorize -ffunction-sections -fdata-sections -Wall -Wextra -Wmissing-declarations -Wshadow -Wpointer-arith -Wcast-qual -Wwrite-strings -Wsign-compare  -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -Wl,--gc-sections -o test/read_conf src/Log.o src/LogBackend.o test/read_conf.o libconf.a libfs.a -lz libsystem.a libutil.a -lgthread-2.0 -pthread -lglib-2.0 -lm 
g++ -pthread -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -fvisibility=hidden -fno-threadsafe-statics -fmerge-all-constants -fno-exceptions -fno-rtti -ffast-math -ftree-vectorize -ffunction-sections -fdata-sections -Wall -Wextra -Wmissing-declarations -Wshadow -Wpointer-arith -Wcast-qual -Wwrite-strings -Wsign-compare  -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -Wl,--gc-sections -o test/run_gunzip test/run_gunzip.o src/Log.o src/LogBackend.o -lgthread-2.0 -pthread -lglib-2.0 libutil.a libfs.a -lz libsystem.a -lm 
g++ -pthread -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -fvisibility=hidden -fno-threadsafe-statics -fmerge-all-constants -fno-exceptions -fno-rtti -ffast-math -ftree-vectorize -ffunction-sections -fdata-sections -Wall -Wextra -Wmissing-declarations -Wshadow -Wpointer-arith -Wcast-qual -Wwrite-strings -Wsign-compare  -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -Wl,--gc-sections -o test/run_filter test/run_filter.o test/FakeReplayGainConfig.o src/Log.o src/LogBackend.o src/filter/FilterPlugin.o src/filter/FilterRegistry.o src/CheckAudioFormat.o src/AudioFormat.o src/AudioParser.o src/ReplayGainInfo.o libfilter_plugins.a libpcm.a -lsoxr -lsamplerate libconf.a libfs.a -lz libsystem.a libutil.a -lgthread-2.0 -pthread -lglib-2.0 -lm 
ranlib libdecoder.a
rm -f libffmpeg.a
ar cru libffmpeg.a src/lib/ffmpeg/libffmpeg_a-Init.o src/lib/ffmpeg/libffmpeg_a-LogError.o src/lib/ffmpeg/libffmpeg_a-LogCallback.o src/lib/ffmpeg/libffmpeg_a-Error.o src/lib/ffmpeg/libffmpeg_a-Domain.o 
ar: `u' modifier ignored since `D' is the default (see `U')
ranlib libmpd.a
ranlib libffmpeg.a
Makefile:7310: recipe for target 'src/archive/plugins/libarchive_a-Iso9660ArchivePlugin.o' failed
make[3]: *** [src/archive/plugins/libarchive_a-Iso9660ArchivePlugin.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[3]: Leaving directory '/<<PKGBUILDDIR>>'
Makefile:4331: recipe for target 'all' failed
make[2]: *** [all] Error 2
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: make -j64 returned exit code 2
debian/rules:135: recipe for target 'override_dh_auto_build' failed
make[1]: *** [override_dh_auto_build] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
debian/rules:119: recipe for target 'binary' failed
make: *** [binary] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit status 2