Bug#493705: libswscale0: The library has text relocations

[Russell Coker]

Package: libswscale0
Version: 0.svn20080206-8
Severity: normal

http://etbe.coker.com.au/2007/02/10/execmod/

The above URL has background information on the execmod denial from SE
Linux.

The following command shows that some parts of the library have not been
comiled with -fpic or -fPIC - in this case it's actually assembly code
which is not position independent.

# eu-findtextrel /usr/lib/libswscale.so.0|uniq

The following patch fixes this.

diff -ru ffmpeg-free-0.svn20080206/libswscale/rgb2rgb.c fixed/libswscale/rgb2rgb.c
--- ffmpeg-free-0.svn20080206/libswscale/rgb2rgb.c	2008-01-29 14:58:10.000000000 +0000
+++ fixed/libswscale/rgb2rgb.c	2008-08-04 10:15:06.000000000 +0000
@@ -158,6 +158,9 @@
 #define RENAME(a) a ## _C
 #include "rgb2rgb_template.c"
 
+/* The MMX, MMX2, and 3DNOW versions all have text relocations */
+# if 0
+
 #if defined(ARCH_X86) && defined(CONFIG_GPL)
 
 //MMX versions
@@ -188,6 +191,7 @@
 #include "rgb2rgb_template.c"
 
 #endif //ARCH_X86 || ARCH_X86_64
+#endif
 
 /*
  rgb15->rgb16 Original by Strepto/Astral