lool at dooz.org
Sun Jan 20 09:53:12 UTC 2008
On Sat, Jan 19, 2008, Fabian Greffrath wrote:
> This is because of kfreebsd-* and hurd-*. I have not checked yet if
> enabling ALSA affects libquicktime-dev dependencies. BTW, it seems
> nobody has missed ALSA support by now. ;)
Ok; I can't speak in favor or against ALSA support in libquicktime, but
for the portability you wanted to achieve, I'd recommend keeping the
same list of features except on kfreebsd-* and hurd-*; you can do this
with this sample snippet:
DEB_HOST_ARCH_OS ?= $(shell dpkg-architecture -qDEB_HOST_ARCH_OS)
# Linux specific flags
configure_flags += --enable-alsa
and update the libasound2-dev build-dep with OS info:
libasound2-dev [!kfreebsd-i386 !kfreebsd-amd64 !hurd-i386]
> > - minor: you touched 20-deprecated-headers and
> > 21-export-quicktime_set_window; these are sourceful differences which
> > should theoritically be mentionned in the changelog ;)
> I only dpatch-edit-patch'ed them to see if the still apply cleanly. I
> find it hard to write a changelog entry for this. ;)
I know the changes are noops, but they are still there which is why I
mention them but as "minor"; I would let it pass to not list them, but
would it be me I'd either not have them or list them in the changelog.
With quilt, I usually only refresh a patch when the push resulted in
some warnings, but with SVN you can always "svn revert" the patch if
the update is useless.
> > - I need a way to generate a tarball suitable for Debian; ideally both
> > of these:
> > * documented in debian/copyright ("download the upstream tarball and
> > do foo")
> > * implemented in debian/rules, for example in the "get-orig-source"
> > target ("wget http://...; tar xzf ...; rm -rf ...; tar czf ...")
> > but one would be enough
> For 'rott' I documented this in README.Debian. Is this allright, too?
I don't think this is enough; it might be useful for end users,
especially if the changes remove some functionality ("stripped encoder
foobar"), but copyright is a more natural place to document it (since
it's where it's explained what the source is and where it comes from).
> > I didn't review the new upstream release itself yet.
> Oops, I didn't check the header files, too. :/
Ok; will wait for this.
> As a further step I'd like to CDBS'ify debian/rules to keep it smaller.
I'm fine with CDBS, but please keep it for the next revision; it would
make my job easier to review it as a separate upload. I recommend you
check the "configure" call (env and flags) and debdiff the results when
doing the switch.
More information about the pkg-multimedia-maintainers