libquicktime 1.0.2

Fabian Greffrath fabian.greffrath at lycos.de
Sun Jan 20 16:59:15 UTC 2008


Hi Loic,

Am Sonntag, den 20.01.2008, 10:53 +0100 schrieb Loïc Minier:
>  Ok; I can't speak in favor or against ALSA support in libquicktime, but
>  for the portability you wanted to achieve, I'd recommend keeping the
>  same list of features except on kfreebsd-* and hurd-*; you can do this
>  with this sample snippet:
>     DEB_HOST_ARCH_OS    ?= $(shell dpkg-architecture -qDEB_HOST_ARCH_OS)
> 
>     # Linux specific flags
>     ifeq ($(DEB_HOST_ARCH_OS),linux)
>     configure_flags += --enable-alsa
>     endif
> 
>  and update the libasound2-dev build-dep with OS info:
>     libasound2-dev [!kfreebsd-i386 !kfreebsd-amd64 !hurd-i386]

Done. However, I inverted the test to disable alsa if (DEB_HOST_ARCH_OS 
!= linux), since it is enabled automatically when the alsa headers are
found. Then again, the test is useless, since the headers will not be
available on systems other than Linux.

>  I know the changes are noops, but they are still there which is why I
>  mention them but as "minor"; I would let it pass to not list them, but
>  would it be me I'd either not have them or list them in the changelog.
>  With quilt, I usually only refresh a patch when the push resulted in
>  some warnings, but with SVN you can always "svn revert" the patch if
>  the update is useless.

I reverted the changes that I introduced in my previous commit.

>  I don't think this is enough; it might be useful for end users,
>  especially if the changes remove some functionality ("stripped encoder
>  foobar"), but copyright is a more natural place to document it (since
>  it's where it's explained what the source is and where it comes from).

I documented it in debian/rules because I believe this is the
appropriate place for source changes like this, i.e. that do not affect
copyright issues but only Debian packaging.


>  Ok; will wait for this.

Done. I have found no API changes in the header files relative to 1.0.0.

>  I'm fine with CDBS, but please keep it for the next revision; it would
>  make my job easier to review it as a separate upload.  I recommend you
>  check the "configure" call (env and flags) and debdiff the results when
>  doing the switch.

Allright. I am looking forward to this.

Cheers,
Fabian




More information about the pkg-multimedia-maintainers mailing list