Changes to the 'rumor' package

Reinhard Tartler siretart at tauware.de
Fri Jul 24 18:57:34 UTC 2009


ryanakca at kubuntu.org writes:

> Hi,
> These patches are fixes made to the rumor package (not yet uploaded to Debian).
>
> I've patched the texinfo document at the request of Rosea Grammostola so that
> the generated info document installs correctly, eliminating this error when
> installing the package:

Thank you very much for your patches. I'm currently testbuilding them.

I have some objections to your patches. E.g. your first patch is
cosmetics that brings all fields in debian/control back to single line
fields. We prefer multiline fields because they are easier to review in
commit diffs.

We prefer to have a single commit handling debian/changelog, please
don't mix changes to debian/changelog with other changes. This way
mistakes can easier be reverted.

moreover, I've squished all relevant patches to your quilt patches. this
makes your commits more focused.

I've applied the other cosmetic and householding changes as well, they
do seem to make sense to me.

again, thanks for your contribution!

-- 
Gruesse/greetings,
Reinhard Tartler, KeyID 945348A4



More information about the pkg-multimedia-maintainers mailing list