Re: Re: LV2

Jaromír Mikeš mira.mikes at seznam.cz
Tue Jun 9 22:09:25 UTC 2009


> Od: Free Ekanayaka <freee at debian.org>

Hi,

FE> Thanks, there were still a few issues which I fixed my self, hope you
FE> don't mind.

Of course not thank you for doing this.

FE> 1) Architecture was set to "any", even though the package doesn't
FE> really have any architecture-dependent part. I've move it "all" and
FE> modified debian/rules accordingly.

I am still beginner ;)

FE> 2) The changelog entry was signed with
> 
FE> Debian Multimedia Team <debian-multimedia at lists.debian.org>
> 
FE> it's okay to user your actual name and email there, so it's more clear
FE> who did what. I fixed that putting your name.

Ok

FE> 3) The repository already had a tag named debian/3.0-1, so I deleted
FE> it manually and re-created it after my commits. In general it's better
FE> to tag the tree only when doing the actual upload, so we are sure to
FE> tag exactly the state of the uploaded package, without leaving out
FE> stuff.

That mean that I as not being DD should not make tag at all?

FE> 4) The debian/copyright file is better, but it still missing some
FE> minor notices like autowaf.py having a different attribution, and
FE> Richard W.E. Furse, Paul Barton-Davis, Stefan Westerfeld not being
FE> mentioned. However I think it's okay like this, just keep in mind to
FE> be extra-careful about debian/copyright, has it's one of most common
FE> reasons of a new package being rejected.

I've improved again debian/copyright ... it can be useful for future update.

Thank you for taking care about this package.

I am planing improve state of slv2 repository same way soon. (tomorrow)
Hope you revise it than.

mira



More information about the pkg-multimedia-maintainers mailing list